-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply #659 to device-orientation-controls, integrating permission dialog into library #661
Open
nickw1
wants to merge
6
commits into
dev
Choose a base branch
from
ios-permission-gesture-in-lib-code
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…log into library
@ma2yama do you want to test this? It's your fix applied to the main library. Thanks. |
@nickw1 Thanks for the fix. I have verified that the modal appears and the cube appears depending on the orientation of the device after pressing the button to allow it. While reviewing the code, I noticed a couple of things:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Introduces the permissions dialog introduced in PR #659 (providing a gesture to initiate device orientation permission request on iOS) into the
DeviceOrientationControls
class within AR.js itself, meaning that users do not need to implement this code themselves.Can it be referenced to an Issue? If so what is the issue # ?
Related to PR #659
How can we test it?
Test either the three.js location-based example or the
basic-js
A-Frame example. Will work as usual on Android, and should display the permissions dialog on iOS. To test the dialog on Android, change theif
statement on line 311 indevice-orientation-controls.js
toif(true)
- it works as expected. Untested on iOS at present.Summary
See "what kind of change does the PR introduce?" - see above
Does this PR introduce a breaking change?
No
Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
Tested on Android, Chrome
Other information
@kalwalt do you want to check this when you're available? Thanks.