Ports: NF's Experimental Garbage Collection System + Shipyard Directions [Thursday Test]#1023
Open
DevArchwave wants to merge 4 commits intoARF-SS13:masterfrom
Open
Ports: NF's Experimental Garbage Collection System + Shipyard Directions [Thursday Test]#1023DevArchwave wants to merge 4 commits intoARF-SS13:masterfrom
DevArchwave wants to merge 4 commits intoARF-SS13:masterfrom
Conversation
Ported Shipyard Direction Message from Monolith
Nf garbage collection
…initialize. More elegant, perhaps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Ports Aurora Song's PR (AuroraSong14/Aurora-Song-14#150) of the NF garbage collection system (new-frontiers-14/frontier-station-14#3574) alongside their port of shipyard directions on console purchase. (AuroraSong14/Aurora-Song-14#105)
Some small changes were made and tailored for coyote, one which is just for the sake of implementation, and a change to the default CVARs of how long it takes for the GC cycle to run.
Why / Balance
Finally, we can clean objects in space.
Technical details
Quoting original PR:
How to test
Requirements
Breaking changes
This means that anytime an admin wishes to make an event grid, they MUST manually add the DeletionCensusExemptComponent to that grid, or it will be deleted by default in 2 hours. Alternatively, we could investigate an implementation in the future to make it so wrenching or initializing a shuttle console or a radar console on any grid ensures the DeletionCensusExemptComponent is added to said grid. @Superlagg probably would like this.
Changelog
Not a player facing feature, no changelog needed.