Open
Conversation
Collaborator
|
This is something we'll need to discuss a lot more before it can be considered, it does affect game balance quite a bit! |
Contributor
Author
|
nodders. feel free to mark as DNM or equivalent in the mean time while you guys get to a resolution 👍 |
Collaborator
Sure thing! Thanks for understanding =3 |
Superlagg
added
the
DNM - Discussion Needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Makes bags of holding their intended 20x10 size. Also lets you put backpacks inside them!
This does not give you free storage; the backpacks take up the same size as they would give you.
And no, you can't put a BOH inside a BOH*. (*Only 'cause I haven't added it going boom :3)
Also lets you put Huge 4x4 stuff in backpacks.
Why / Balance
Bags of holding right now are only slightly better than a duffel bag, which kind of makes them not super worth it.
Also it's weird I can't fit a jetpack/breachhammer in a backpack, even though it's 4x4.
Technical details
New
item_size.ymlfor... probably just this one.How to test
Spawn in a bag of holding, observe its size.
Stuff a few cats in there. And a hardsuit for good measure.
Media
Requirements
Breaking changes
Bags of holding were reparented, this shouldn't cause any issues though?
Changelog