Bump cmake minimum required to 3.21 for ARMClang compatibility - #240
Merged
Conversation
Selecting the newer CMake policy baseline enables CMP0123=NEW, which stops CMake from automatically deriving ARMClang architecture flags from CMAKE_SYSTEM_PROCESSOR and the undocumented CMAKE_SYSTEM_ARCH. With the old policy behavior, CMake's ARMClang platform logic attempted to construct an -march option even when no architecture value was available, resulting in an invalid empty -march= flag with newer CMake. Use the CMP0123 NEW behavior instead, leaving CPU/architecture selection to the toolchain and avoiding the invalid compiler option. Change-Id: Ib0052e6b1f7c8f46d74d0f367ca80bb4111a7938
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting the newer CMake policy baseline enables CMP0123=NEW, which stops CMake from automatically deriving ARMClang architecture flags from CMAKE_SYSTEM_PROCESSOR and the undocumented CMAKE_SYSTEM_ARCH.
With the old policy behavior, CMake's ARMClang platform logic attempted to construct an -march option even when no architecture value was available, resulting in an invalid empty -march= flag with newer CMake.
Use the CMP0123 NEW behavior instead, leaving CPU/architecture selection to the toolchain and avoiding the invalid compiler option.