SX1276: Dynamic TCXO control #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two issues with TCXO on SX1276 resolved: - If TCXO pin has been configured, TCXO is disabled when the radio goes to sleep. - Set the TcxoInputOn bit properly and provide an interface to set the correct value for the particular board/SoC. TCXO control is required for low-power applications; keeping it always enabled consumes ~1.2 mA which is unacceptable for most battery powered devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues with TCXO on SX1276 resolved:
to sleep.
correct value for the particular board/SoC.
TCXO control is required for low-power applications; keeping it always enabled consumes ~1.2 mA which is unacceptable for most battery powered devices.
This might not be directly mergeable as such, but more like starting point... the main question is how the added member function set_board_tcxo_params() should be handled. Currently it's just a new non-virtual member function for this radio only. Options could be adding the parameter(s) to the constructor of SX1276_LoRaRadio or making the interface available in the virtual base class (LoRaRadio).
Also, I'm wondering if an explicit parameter for tcxo_input_on is really needed or should TcxoInputOn bit just become enabled always when a tcxo pin other than NC is given.
The logic for enabling/disabling the TCXO is modeled after LoRaMac-node where the dynamic TCXO enabling has been implemented.