Forward SFT gradient accumulation to MLX-LM#17
Open
kargarisaac wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SFTConfig.gradient_accumulation_stepsinto MLX-LMTrainingArgsWhy
SFTTraineralready reads and storesgradient_accumulation_steps, but the native MLX training path did not pass it intomlx_lm.tuner.trainer.TrainingArgs, so MLX-LM used its default of1.This makes the Unsloth-compatible
SFTConfig(gradient_accumulation_steps=...)behave as expected for native SFT training.Tests
.venv/bin/python -m pytest tests/test_trainers.py -q # 16 passed .venv/bin/python -m py_compile mlx_tune/sft_trainer.py tests/test_trainers.py git diff --checkNotes:
uv run pytest tests/test_trainers.py -qcurrently fails during dependency resolution before tests run becausepyproject.tomlallows Python>=3.9, whilemlx>=0.31.0requires Python>=3.10.ruff check mlx_tune/sft_trainer.py tests/test_trainers.pyreports pre-existing style issues in these files, so I did not broaden this bugfix PR into a formatting cleanup.