Conversation
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
Ben926
reviewed
Mar 28, 2025
| RemarkCommand.MESSAGE_USAGE), ive); | ||
| } | ||
|
|
||
| String remark = argMultimap.getValue(PREFIX_REMARK).orElse(""); |
| * The first character of the address must not be a whitespace, | ||
| * otherwise " " (a blank string) becomes a valid input. | ||
| */ | ||
| public static final String VALIDATION_REGEX = "[^\\s].*"; |
| phone = new Phone(DEFAULT_PHONE); | ||
| email = new Email(DEFAULT_EMAIL); | ||
| address = new Address(DEFAULT_ADDRESS); | ||
| remark = new Remark(DEFAULT_REMARK); |
There was a problem hiding this comment.
I like that you added test to this command
|
I believe this should be closed, as this is done in another pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.