Skip to content

Conversation

mentatbot[bot]
Copy link
Contributor

@mentatbot mentatbot bot commented Apr 21, 2025

This PR addresses issue #32 with the following changes:

  1. Updated the package.json to make ESLint fail on warnings by adding --max-warnings=0 flag to the lint script
  2. Fixed all 13 ESLint warnings in the frontend code:
    • Removed unused imports and variables
    • Added missing component display name
    • Replaced any types with proper types (unknown or specific component types)
  3. Updated CI workflow step description to clarify that ESLint will fail on warnings

These changes ensure higher code quality by preventing ESLint warnings from passing CI checks.

Closes #32


🤖 See my steps and cost here

  • Wake on any new activity.

This PR addresses issue # 32 with the following changes:

1. Updated the package.json to make ESLint fail on warnings by adding `--max-warnings=0` flag to the lint script
2. Fixed all 13 ESLint warnings in the frontend code:
   - Removed unused imports and variables
   - Added missing component display name
   - Replaced `any` types with proper types (`unknown` or specific component types)
3. Updated CI workflow step description to clarify that ESLint will fail on warnings

These changes ensure higher code quality by preventing ESLint warnings from passing CI checks.

Closes # 32

Mentat precommits passed. Log: https://mentat.ai/log/7e4fc768-fcc8-4260-8e60-0328f8b6f1da
Copy link
Contributor Author

mentatbot bot commented Apr 21, 2025

Hi @jakethekoenig,

I've completed all the requested changes for issue #32:

  1. Made ESLint fail on warnings by adding the --max-warnings=0 flag to the lint script in package.json
  2. Fixed all 13 ESLint warnings in the frontend code:
    • Fixed unused variables and parameters in event handlers
    • Removed unused imports
    • Added a missing display name to the RepositoryGraph component
    • Replaced all instances of any type with proper types (unknown or Component)
  3. Updated the CI workflow step description to better reflect that ESLint will now fail on warnings

The PR is ready for review. All tests are passing, and the code should now maintain higher quality standards by preventing ESLint warnings from passing CI checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't allow warnings on frontend
0 participants