Skip to content

Conversation

@anton-ubi
Copy link
Contributor

@anton-ubi anton-ubi commented Dec 20, 2025

Problem

When an RQD instance restarts with a different version, the version tag (rqdv-X) in CueCommander is not being updated. The tags remain stuck at the first registered version despite the RQD instance reporting the correct new version on startup.

Root Cause

There is no mechanism to update host tags when an existing RQD instance reconnects with different version information. Tags are only set during initial host creation and remain static afterwards.

Solution

  • New updateHostTags method to handle tag updates on host reconnection
  • Method removes existing RQD-related tags and replaces them with current values from the host report
  • Use HostTagType.HARDWARE for RQD tags to distinguish them from user-added manual tags

Note: HostTagType.HARDWARE seemed unused. I don't know if a different usage was planned for it. It seems a good contender to segregate easily tags added at creation from manual tags added by the user later.

Testing

Update related unit tests to reflect the new tag ordering after the type classification change.
Add coverage to ensure manual tags are left untouched.

@anton-ubi anton-ubi changed the title [cuebot][fix] hardware tags update on Host restart [cuebot][FIX] HARDWARE tags update on Host restart Dec 20, 2025
@anton-ubi anton-ubi changed the title [cuebot][FIX] HARDWARE tags update on Host restart [cuebot][FIX] Hardware tags update on Host restart Dec 20, 2025
Copy link
Collaborator

@DiegoTavares DiegoTavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking back at the history of HostTagType.HARDWARE it was added to the original cue3 project 17 years ago and has never been used. I think it is safe to repurpose for marking tags that have been added by rqd at boot time.

One side effect of this PR in its current state is that hosts existing prior to its deployment might have duplicate tags, as updateTagsByType only purges tags by type and new HARDWARE tags might already exist as MANUAL. This can be mitigated by also removing tags by name using HostDao's method void removeTag(HostInterface host, String tag);

@anton-ubi
Copy link
Contributor Author

Addressed. Also added a test to cover that case.

@anton-ubi anton-ubi requested a review from DiegoTavares January 6, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants