dynamic analysis #233
dynamic analysis #233
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
==========================================
+ Coverage 84.98% 85.48% +0.50%
==========================================
Files 11 11
Lines 2165 2164 -1
Branches 326 326
==========================================
+ Hits 1840 1850 +10
+ Misses 325 314 -11 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Anton Dukhovnikov <[email protected]>
antond-weta
force-pushed
the
dynamic_analysis
branch
from
e3011e1 to
ff5dac5
Compare
| -D CMAKE_CXX_STANDARD=17 | ||
| -D CMAKE_BUILD_TYPE=${{ inputs.build_type }} | ||
| -D CMAKE_TOOLCHAIN_FILE="${{ inputs.toolchain_file }}" | ||
| -D CMAKE_BUILD_TYPE="${{ inputs.build_type }}" |
There was a problem hiding this comment.
it is already there on line 107
There was a problem hiding this comment.
I guess that didn't work without quotes. Fixed.
| - name: Run sanitiser checks | ||
| if: inputs.sanitiser_mode != 'none' | ||
| working-directory: build/src/rawtoaces |
There was a problem hiding this comment.
inside script (run_valid.sh) it says # Execute from the build directory of the CLI tool but we run it from a different place here.
There was a problem hiding this comment.
This is the built binary location, assuming 'build' is the build folder. Is it different for you?
| elseif ( "${RTA_SANITISER_MODE}" STREQUAL "thread" ) | ||
| set ( RTA_SANITISER_COMPILE_OPTIONS "-fsanitize=thread" "-g" "-O1" ) | ||
| set ( RTA_SANITISER_LINK_OPTIONS "-fsanitize=thread" "-g" ) | ||
| endif () |
There was a problem hiding this comment.
do we care for else here with smth like
message(FATAL_ERROR "Invalid RTA_SANITISER_MODE: ${RTA_SANITISER_MODE}") ?
soswow
left a comment
soswow
left a comment
There was a problem hiding this comment.
nice. there is one duplicate line, all rest is LGTM
Signed-off-by: Anton Dukhovnikov <[email protected]>
|
send it! |
antond-weta
merged commit 2128cbc
into
AcademySoftwareFoundation:main
3 participants
Description
This adds cmake config and CI actions to run dynamic analysis.
Currently only the address and thread sanitisers are configured to run on CI, although the memory sanitiser can be run locally (I believe the OpenSSF badge only requires these three).
Currently the dynamic analysis gets run on the valid permutations of the WB and matrix methods (tests/run_valid.sh), I will add a script generating the launch commands for various permutations of invalid inputs later as a separate PR.
Tests
These are tests.
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.