Replace mholt/archiver with mholt/archives. #3757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mitchell-as
force-pushed
the
mitchell/cp-1080
branch
from
fc9468a to
feb27a3
Compare
mitchell-as
added
Test: critical
Test: checkout
and removed
Test: update
Test: checkout
labels
Revert "Try to fix hardlink failures." This reverts commit feb27a3. Update unarchiver.go
mitchell-as
force-pushed
the
mitchell/cp-1080
branch
from
c5ad155 to
4c6c55c
Compare
Collaborator
Author
|
Test failures are consistent with currently known nightly failures. This PR doesn't introduce any new failures, yay! |
tjsanterre
approved these changes
Nov 24, 2025
MDrakos
approved these changes
Nov 24, 2025
Member
MDrakos
left a comment
MDrakos
left a comment
There was a problem hiding this comment.
This looks good to me. With a change like this I would feel better having the integration tests passing before we do a release but that's something we will follow up with after this has been merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have our own
internal/archiverandinternal/unarchiverpackages that leverage mholt/archiver, but subclass it in order to provide progress support (i.e. report back for each file extracted). However, we don't actually use that feature.I've switched over to the mholt/archives library, which allows for progress support should we want it, but I didn't add it back in since there's no use case for it.
A majority of this PR is a result of
I did find some places in our code where we were invoking mholt/archiver directly. I changed those to invoke our
internal/archiverandinternal/unarchiverpackages. Now only those internal packages talk to mholt/archives should we ever have to change libraries again.