feat: fix buggy autostart minimized.

[0xbrayo]

#56

---

Important

Fixes autostart minimized behavior by correcting window visibility logic in lib.rs and updating tauri.conf.json.

• Behavior:
  • Fixes logic in run() in lib.rs to correctly show the main window when autostart is true and autostart_minimized is false.
  • Updates tauri.conf.json to set visible to false for the main window, ensuring it starts minimized by default.
• Misc:
  • No changes to support additional sub-events or error logging.

^{This description was created by for 50de04f. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 50de04f in 1 minute and 3 seconds

More details

• Looked at 32 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 5 drafted comments based on config settings.

1. src-tauri/src/lib.rs:482

• Draft comment:
  Changed autostart_minimized check seems to invert the logic intentionally. Confirm that when autostart_minimized is false the window should show on non-first run.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

2. src-tauri/tauri.conf.json:12

• Draft comment:
  Setting 'visible': false makes the window hidden on startup. Ensure this aligns with the intended autostart behavior.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

3. src-tauri/src/lib.rs:482

• Draft comment:
  Reversed autostart_minimized condition: Now the code calls window.show() when autostart is enabled and autostart_minimized is false. Confirm this matches the intended behavior (i.e. show the window when not minimized, and keep hidden otherwise). Also, the use of !*is_first_run() is key—ensure that first-run behavior is as expected.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 30% <= threshold 50%
  The comment is asking the PR author to confirm the intended behavior, which violates the rule against asking for confirmation of intention. However, it also provides a specific observation about the code change, which is useful. The part about ensuring first-run behavior is as expected is also asking for confirmation, which is not allowed. Overall, the comment is mostly about confirming intentions, which is not allowed.

4. src-tauri/tauri.conf.json:12

• Draft comment:
  Setting "visible": false ensures the main window starts hidden by default. This supports the autostart minimized feature. Verify this aligns with overall UX expectations.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  The comment is informative and asks the PR author to verify alignment with UX expectations, which is against the rules. It doesn't provide a specific code suggestion or ask for a specific test to be written.

5. src-tauri/src/lib.rs:369

• Draft comment:
  Typo detected: In the error message on line 369, 'Unable to disable autosart' should likely be corrected to 'Unable to disable autostart'.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_cXO3uG8gE0QCNRb6

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.