Skip to content

fix(macos): don't relaunch a browser that quit while frontmost #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErikBjare merged 2 commits into from
Oct 6, 2026
+22 −4
Merged

fix(macos): don't relaunch a browser that quit while frontmost #152

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
952759e
fix(macos): don't relaunch a browser that quit while frontmost
TimeToBuildBob Oct 2, 2026
f15ef16
fix(macos): distinguish quit from proxy-creation failure in browser g…
TimeToBuildBob Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions aw_watcher_window/macos.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,11 +603,20 @@ class MainThing {
if CHROME_BROWSERS.contains(applicationName) {
debug("Chrome browser detected, extracting URL and title")

guard let bundleIdentifier = frontmost.bundleIdentifier else {
guard frontmost.bundleIdentifier != nil else {
log("Failed to get bundle identifier from frontmost application, which was recognized to be Chrome")
return
}
let chromeObject: ChromeProtocol = SBApplication.init(bundleIdentifier: bundleIdentifier)!
// Address the running process by PID and bail if it already quit: a
// bundle-identifier target makes ScriptingBridge relaunch a browser that just quit.
guard !frontmost.isTerminated else {
log("Chrome is no longer running, skipping scripting request")
return
}
guard let chromeObject = SBApplication.init(processIdentifier: frontmost.processIdentifier) as? ChromeProtocol else {
log("Failed to create ScriptingBridge proxy for Chrome")
return
}

guard let windows = chromeObject.windows,
let frontWindow = windows().first else {
Expand Down Expand Up @@ -638,11 +647,20 @@ class MainThing {
} else if frontmost.localizedName == "Safari" {
debug("Safari browser detected, extracting URL and title")

guard let bundleIdentifier = frontmost.bundleIdentifier else {
guard frontmost.bundleIdentifier != nil else {
log("Failed to get bundle identifier from frontmost application, which was recognized to be Safari")
return
}
let safariObject: SafariApplication = SBApplication.init(bundleIdentifier: bundleIdentifier)!
// Address the running process by PID and bail if it already quit: a
// bundle-identifier target makes ScriptingBridge relaunch a browser that just quit.
guard !frontmost.isTerminated else {
log("Safari is no longer running, skipping scripting request")
return
}
guard let safariObject = SBApplication.init(processIdentifier: frontmost.processIdentifier) as? SafariApplication else {
log("Failed to create ScriptingBridge proxy for Safari")
return
}

guard let windows = safariObject.windows,
let frontWindow = windows().first else {
Expand Down
Loading