adagrams by unkcodesquick · Pull Request #20 · Ada-C10/adagrams

unkcodesquick · 2018-08-17T23:24:38Z

Adagrams

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature	Feedback
What are the components that make up a method?	method signature, parameters, method block
What are the advantages of using git when collaboratively working on one code base?	ability to track changes and work off different machines.
What kind of relationship did you and your pair have with the unit tests?	lower engagement than expected, but they were very helpful guiding us - good to see how they were structured to help guide thought process for creating methods.
Does your code use any methods from the `Enumerable` mixin? If so, where and why was it helpful?	select, reduce, min_by- they were helpful to parse through sets of information and return a single value. they helped dry up our code.
What was one method you and your pair used to debug code?	we used pry - to look at what variables/data types to see if they matched our plans/expectations
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	How our code hygiene has decreased since we've learned more code - we wished we did more whiteboarding and psuedocode instead of going straight to writing code.

… 'word', score: integer)

dHelmgren · 2018-08-24T17:42:41Z

Adagrams

What We're Looking For

Feature	Feedback
General
Answered comprehension questions	Good answers
Both teammates contributed to the codebase	YEAH!
Small commits with meaningful commit messages	Good, small, well spoken commits!
Code Requirements
`draw_letters` method	Besides the issue below, well structured and readable.
Uses appropriate data structure to store the letter distribution	Your hash actually doesn't do the appropriate task!
All tests for `draw_letters` pass	Pass!
`uses_available_letters?` method	It works, though you've created a little more work for yourself and for the computer than you needed to. I don't think that converting the arrays to hashes actually helps performance or clarity.
All tests for `uses_available_letters?` pass	P-P-P-Pass!
`score_word` method	See comments. This works, but gosh it's not very clear what's happening.
Uses appropriate data structure to store the letter scores	I do think that using a fixed value hash for the scoring scheme is a great idea!
All tests for `score_word` pass	Pass!
`highest_score_from` method	Oooh, this is full of spiffy one liners! Do be aware of using enumerables too much though. Each enumerable hides a loop from you.
Appropriately handles edge cases for tie-breaking logic	This was a very clever and readable solution.
All tests for `highest_score_from` pass	Pass!
Overall	Your code all works correctly, however, it seems like you tried to use the same tool to solve most problems. Hashes are really great for some of the things you are trying to do, but arrays are a better option in as many cases. Let me know if you want some help understanding why some of these situations called for different data structures.

dHelmgren · 2018-08-24T17:42:47Z

lib/adagrams.rb

+def draw_letters
+  letter_bank = Array.new
+  10.times do
+    random_letter_picked = LETTERS_TO_QUANTITY.keys.sample


So, you have a probability problem here. When you sample from the keys, the odds are not weighted by the number of each tile in the letter_bank. Your results give a 1/26 chance to draw any letter, but that's not accurate is it?

dHelmgren · 2018-08-24T17:42:54Z

lib/adagrams.rb

+
+def uses_available_letters?(user_input_word, letter_bank)
+  array_of_input_letters = user_input_word.split('')
+  letter_bank_hash = letters_to_hash(letter_bank)


Is there any reason you couldn't have done this with 2 arrays?

dHelmgren · 2018-08-24T17:42:57Z

lib/adagrams.rb

+  user_input_letters_hash = letters_to_hash(array_of_input_letters)
+  output = true
+  user_input_letters_hash.each do |key,value|
+    if !letter_bank_hash.keys.include?(key) # look at looping of outputs, see what happens if use


As soon as one of these is false, do you need to check the whole hash still?

dHelmgren · 2018-08-24T17:42:59Z

lib/adagrams.rb

+      user_input_word_hash.each do |word_key, word_value|
+        SCORE_TO_LETTERS.each do |score_key, score_value|
+          if score_value.include?(word_key)
+            score = score_key*word_value


It took me a minute to see why this works. Again, using a hash here is actually more work for you, and hindering clarity.

dHelmgren · 2018-08-24T17:43:01Z

lib/adagrams.rb

+          end
+        end
+      end
+      total_score =  array_of_letter_scores.reduce(:+)


reduce is hiding a loop from you, though you could have used reduce to solve this problem by replacing an earlier .each.

dHelmgren · 2018-08-24T17:43:05Z

lib/adagrams.rb

+
+def highest_score_from(played_words)
+  collection_of_played_words_and_scores = []#array of hashes
+  played_words.each do |word|


nice! I love this, very clear!

dHelmgren · 2018-08-24T17:43:07Z

lib/adagrams.rb

+    played_word_to_score[:score] = score_word(word)
+    collection_of_played_words_and_scores.push(played_word_to_score)
+  end
+  top_score = collection_of_played_words_and_scores.reduce(0){ |memo, h| h[:score] > memo ? h[:score] : memo } # ==> {score: n}


Yum, this is also great!

sjlee3157 and others added 16 commits August 13, 2018 16:46

wave1 first attempt

47657fe

Completed wave 1 requirements for draw_letters method

3653a56

renamed variable players_hand_of_ten to letter_bank

9d27901

updated method uses_available_letters?

0e8641d

completed wave 2 without scoring

639abf5

wave_3 - added method score_word

2ef26bb

Unknown why rake is aborting. Ruled out minitest/skip_dsl as the issue.

02799ea

added hopefully useful numbering to spec tests

a38aa3b

fixed user input = 0, score = 0

2473f24

added part 1 of highest score method, creating array of hashes (word:…

8f469db

… 'word', score: integer)

calculated highest score in highest_score method

c76081a

new features in highest_score_from method for ties, tests failed

6ab9fbf

added tie preference to highest_score method

c888cfa

un-xed final test in spec; added require pry to adagrams.rb

7c25155

Created two constants - letters_to_quantity & score_to_letters

583d09f

finished adagrams

901f159

dHelmgren reviewed Aug 24, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adagrams#20

adagrams#20
unkcodesquick wants to merge 16 commits intoAda-C10:masterfrom
unkcodesquick:master

unkcodesquick commented Aug 17, 2018

Uh oh!

dHelmgren commented Aug 24, 2018

Uh oh!

dHelmgren Aug 24, 2018

Uh oh!

dHelmgren Aug 24, 2018

Uh oh!

dHelmgren Aug 24, 2018

Uh oh!

dHelmgren Aug 24, 2018

Uh oh!

dHelmgren Aug 24, 2018

Uh oh!

dHelmgren Aug 24, 2018

Uh oh!

dHelmgren Aug 24, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

unkcodesquick commented Aug 17, 2018

Adagrams

Comprehension Questions

Uh oh!

dHelmgren commented Aug 24, 2018

Adagrams

What We're Looking For

Uh oh!

dHelmgren Aug 24, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Aug 24, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Aug 24, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Aug 24, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Aug 24, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Aug 24, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Aug 24, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants