Open
Conversation
flash working, application html fixed, can recognize user
Schema fixes
Remove merge conflict markers from routes.rb
Fixed formatting in application view
Added basic navigation for testing purposes
…nships, and model methods
…ts are failing and need work
Added basic functionality to add product to an order (aka cart)
Completed order and orderproduct controller testing & includes resolutions from merge with Jessie's work
Themed seeds!
Small front-end tweaks, product show page design
Styled all forms
bEtsyWhat We're Looking For
Only the person who submitted the PR will get an email about this feedback. Please let the rest of your team know about it. |
dHelmgren
reviewed
Nov 9, 2018
|
|
||
| <p> | ||
| <%= image_tag(@product.photo_url) %> | ||
| </p> |
There was a problem hiding this comment.
Not sure why this is a
tag. This would be better incapsulated by a
tag| </p> | ||
| <%end%> | ||
|
|
||
| <p><%= @product.description%></p> |
There was a problem hiding this comment.
Could this be a <details> or <aside> tag instead of a <p> tag? the <p> tells me almost nothing.
| font-size: 1rem; | ||
| } | ||
|
|
||
| div.form-check-inline > input { |
| @@ -0,0 +1,26 @@ | |||
| class CategoriesController < ApplicationController | |||
| def new | |||
There was a problem hiding this comment.
no controller filter for login, so I can see the new categories page without authorization
| end | ||
|
|
||
| def update | ||
| if @current_order.update(order_user_params) && @current_order.submit_order |
There was a problem hiding this comment.
This seems like the path that you use for checkout, but it doesn't try to confirm that all the products in the cart are still available.
| end | ||
|
|
||
| it "Can log in a new user with good data" do | ||
| # Arrange |
There was a problem hiding this comment.
This test fails with the following error
test_0002_Can log in a new user with good data FAIL (0.03s)
"User.count" didn't change by -1.
Expected: 5
Actual: 9
test/controllers/sessions_controller_test.rb:22:in `block (3 levels) in <top (required)>'
| describe "create" do | ||
| #remember merchants are a subclass of user, so will be included in count as well | ||
| it "Can log in an existing user" do | ||
| # Arrange |
There was a problem hiding this comment.
This controller test is very similar to the one in your user's path, and also fails
test_0001_Can log in an existing user FAIL (0.04s)
"User.count" didn't change by 0.
Expected: 7
Actual: 9
test/controllers/sessions_controller_test.rb:11:in `block (3 levels) in <top (required)>'
| describe ReviewsController do | ||
| # it "must be a real test" do | ||
| # flunk "Need real tests" | ||
| # end |
| end | ||
|
|
||
| it "will not create a new merchant if type is nil" do | ||
| not_a_merchant = Merchant.new( |
There was a problem hiding this comment.
This test fails with the following error
test_0005_will not create a new merchant if type is nil FAIL (0.00s)
Expected #<Merchant id: nil, created_at: nil, updated_at: nil, name: "Newbie", address: nil, cc_num: nil, type: nil, cc_exp: nil, bill_zip: nil, cc_csv: nil, uid: 890, provider: "github", email: "newbie@newbs.com", status: "active"> to not be an instance of Merchant.
test/models/merchant_test.rb:35:in `block (2 levels) in <top (required)>'
| let(:user) { users(:cc_user) } | ||
|
|
||
| it "changes a user instance into a merchant instance if type is set to Merchant" do | ||
| #before! |
There was a problem hiding this comment.
this test fails with the following error
test_0001_changes a user instance into a merchant instance if type is set to Merchant FAIL (0.01s)
Expected #<User id: 1069983167, created_at: "2018-11-09 00:09:42", updated_at: "2018-11-09 00:09:52", name: "hannah", address: "123 Main St USA", cc_num: "8790451276789084", type: "Merchant", cc_exp: "2009-08-22 00:00:00", bill_zip: 10012, cc_csv: 678, uid: 97532187, provider: "github", email: nil, status: "active"> to not be an instance of User.
test/models/user_test.rb:64:in `block (3 levels) in <top (required)>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bEtsy
Congratulations! You're submitting your assignment! These comprehension questions should be answered by all members of your team, not by a single teammate.
Comprehension Questions