Amanda Ungco Hotel -Attempt #1 by unkcodesquick · Pull Request #48 · Ada-C10/hotel

unkcodesquick · 2018-09-12T06:25:48Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	I wanted to put an instance of room in the reservation objects but ultimately took it out because when testing my code, I got stuck in an infinite loop of my reservation referencing a room which was referencing a reservation which was referencing a room. I decided the object of room was unnecesarry to the reservation class and instead added just the room ID to the reservation.
Describe a concept that you gained more clarity on as you worked on this assignment.	Class methods, the use of self, how classes interact.
Describe a nominal test that you wrote for this assignment.	Expecting that any of my methods that asked for a list was returning an array and that the first element in the array was an instance of a class.
Describe an edge case test that you wrote for this assignment.	I did not get to write very many edge cases which i'm sure I will find when i continue to work with my code, but one edge case was dealing with overlapping dates, in my tests to reserve a room and return available rooms, I accidentally created a bunch of overlapping reservations which was great to build an accidental edge case.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I like the method, I think the most difficult part is deciding on and diving into a design. As my code stands now, it only works with the tests I've created, I want to add a lot more edge cases to make sure the program can handle much more.

… room to new reservation

…s probably sad

dHelmgren · 2018-09-20T20:31:02Z

Hotel

What We're Looking For

Feature	Feedback
Baseline
Used git regularly	Yeah!
Answer comprehension questions	Yep!
Design
Each class is responsible for a single piece of the program	Yeah!
Classes are loosely coupled	So, your `reservation_manager` ends up pretty tightly coupled with your other classes. You can mitigate this by using Factory methods to set up your rooms, and by using duck typing to keep calls outside of `reservation_manager` from being stuck in lock step with the other classes.
Wave 1
List rooms	ReservationManager#rooms
Reserve a room for a given date range	ReserMgr#reserve_room
List reservations for a given date	ReserMgr#booked_reservations
Calculate reservation price	Reservation#total_cost
Invalid date range produces an error	Yep!
Test coverage	Needs more edge cases!
Wave 2
View available rooms for a given date range	ReserMgr#available_rooms
Reserving a room that is not available produces an error	It doesn't appear to be possible given your setup, but it seems you don't create an error for the case where there aren't enough rooms.
Test coverage	Needs more edge cases
Wave 3
Create a block of rooms	create_block
Check if a block has rooms	No
Reserve a room from a block	WIP code
Test coverage	Tests are somewhat fleshed out, mostly complete.
Fundamentals
Names variables, classes and modules appropriately	Yea!
Understanding of variable scope - local vs instance	Yes!
Can create complex logical structures utilizing variables	Yes!
Appropriately uses methods to break down tasks into smaller simpler tasks	Yeah, but you could do this even more!
Understands the differences between class and instance methods	Yes
Appropriately uses iterators and enumerables	Hella!
Appropriately writes and utilizes classes	Yes!
Appropriately utilizes modules as a mechanism to encapsulate functionality	Yees!
Wrap Up
There is a refactors.txt file	There is!
The file provides a roadmap to future changes	It's brief, but there are road mapped changes there. Were there any more you were considering?
Additional Feedback	So, you are missing some tests that would improve your code, and you didn't get far into wave 3, which effects the outcome here. What would a jerk do to intentionally break your code? Test THAT.

dHelmgren · 2018-09-20T18:52:23Z

lib/reservations_manager.rb

+      @blocks = []
+      @rooms = []
+      (1..number_of_rooms).each do |number|
+        @rooms << Room.new(number)


This should be a factory method in Room.

dHelmgren · 2018-09-20T18:57:26Z

lib/reservations.rb

+
+
+
+    def initialize(number, number_of_rooms:1, check_in:, check_out:, discount_rate: 1)


number is not a great name for this parameter. I'd opt for something like id_num

dHelmgren · 2018-09-20T19:03:06Z

lib/reservations_manager.rb

+    def reserve_room(check_in, check_out, number_of_rooms: 1 )
+      new_reservation = Reservation.new(@reservations.length + 1, check_in: check_in, check_out: check_out)
+      assigned_rooms = available_rooms(check_in, check_out).last(number_of_rooms)
+      assigned_rooms.each do |room|


What happens if there aren't enough rooms?

dHelmgren · 2018-09-20T19:05:18Z

lib/reservations_manager.rb

+      assigned_rooms = available_rooms(check_in, check_out).last(number_of_rooms)
+      assigned_rooms.each do |room|
+        new_reservation.rooms << room.id
+        find_room(room.id).reservations << new_reservation


in lieu of doing these here, I would give Room and Reservation a method to make the assignment. It's a small but important piece of making your code more loosely coupled.

dHelmgren · 2018-09-20T19:11:24Z

lib/reservations_manager.rb

+      new_reservation = Reservation.new(@reservations.length + 1, check_in: check_in, check_out: check_out)
+      assigned_rooms = available_rooms(check_in, check_out).last(number_of_rooms)
+      assigned_rooms.each do |room|
+        new_reservation.rooms << room.id


Does this work? I only see an attr_reader?

dHelmgren · 2018-09-20T19:24:35Z

spec/reservations_manager_spec.rb

+      expect(@hotel_ada.booked_reservations(@test_date)).must_be_kind_of Array
+      #binding.pry
+      expect(@hotel_ada.booked_reservations(@test_date)[0]).must_be_instance_of Hotel::Reservation
+      expect(@hotel_ada.booked_reservations(@test_date).length).must_equal 3


What does your program do if it isn't handed a proper date?

dHelmgren · 2018-09-20T19:28:41Z

spec/reservations_manager_spec.rb

+      #binding.pry
+      expect(@hotel_ada.available_rooms('2018-08-20', '2018-08-23').length).must_equal 16
+      expect(@hotel_ada.available_rooms('2018-08-20', '2018-08-23')[0]).must_be_kind_of Hotel::Room
+      #expect(@hotel_ada.available_rooms("08.23.2018", "08.25.2018")[0].id).must_equal #rooom ID


You should be testing to see that the code can handle different kinds of reservation date collisions here, not merely that you are getting the right data types!

unkcodesquick added 30 commits September 4, 2018 13:41

Add coverage directory to .gitignore file

da1fe49

created room spec tests

d4e674e

Settled on reservations manager class

9edc68c

removed list method

f683f66

spike - built reservation manager and room classes

020026a

updated spec_helper.rb

16b4e35

final design

8314ff0

keyword arguments

6f963c6

removed is_available method, save for wave 2

d0a6545

passed all tests, added reserve_room method

5f01796

added test to reservation mgr about reserving room, added instance of…

914e35a

… room to new reservation

Added test to check room id of reservation

f7791af

Added find_room method and added instance of reservation to room object

9fb7b66

added booked_reservations method and tests

891c3c4

add find_reservatin method to reservation clas

f3c744c

added find_reservation

92f91e3

passed all tests

b58469a

fixed booked reservations method

e57bce7

added total cost method

85afc9a

trying to debug is_booked, returning false for everything

9a0fbe5

fixed bug in available rooms method

224ff5c

fixed some tests for available_rooms

8079dd0

added overlaps? method to make a helper for is_booked.. sandi metz i…

7ab2ea2

…s probably sad

fixed available rooms method, need to add more tests

70f1cc1

added argument error for invalid dates

16808df

added block method

dc3cc35

fixing total cost method

a00b55d

fix block, currently handling multiple rooms in a re, not a block

74a930a

fixed total cost method

aa11f95

fixed total cost method

f612f12

unkcodesquick added 5 commits September 12, 2018 13:06

added tests for block method and class

e63259f

added create block and introduced reserve block room

2f43112

commented out reserve block, save for next refactor

f47bc6f

updated refactors.txt

e62cca2

updated refactors.txt

b2ec51e

dHelmgren reviewed Sep 20, 2018

View reviewed changes

unkcodesquick added 6 commits September 25, 2018 11:04

Design-activity

2d4bb1d

updated design activity/refactors

4ef099c

updated refactor/design activity

62d4e08

added block spec and changed reserve room method

7cb3090

pseudo code in reservations method in reservation manager class

523842a

updated available rooms method, fixing reserveroom/block functionality

6d54c6d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Amanda Ungco Hotel -Attempt #1#48

Amanda Ungco Hotel -Attempt #1#48
unkcodesquick wants to merge 41 commits intoAda-C10:masterfrom
unkcodesquick:master

unkcodesquick commented Sep 12, 2018 •

edited

Loading

Uh oh!

dHelmgren commented Sep 20, 2018

Uh oh!

dHelmgren Sep 20, 2018

Uh oh!

dHelmgren Sep 20, 2018

Uh oh!

dHelmgren Sep 20, 2018

Uh oh!

dHelmgren Sep 20, 2018

Uh oh!

dHelmgren Sep 20, 2018

Uh oh!

dHelmgren Sep 20, 2018

Uh oh!

dHelmgren Sep 20, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants




		def initialize(number, number_of_rooms:1, check_in:, check_out:, discount_rate: 1)

Conversation

unkcodesquick commented Sep 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Hotel

Comprehension Questions

Uh oh!

dHelmgren commented Sep 20, 2018

Hotel

What We're Looking For

Uh oh!

dHelmgren Sep 20, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Sep 20, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Sep 20, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Sep 20, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Sep 20, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Sep 20, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Sep 20, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

unkcodesquick commented Sep 12, 2018 •

edited

Loading