Margaret #4
Open
Margaret #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Oct 18, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Hey Margaret,
This is almost perfect, but for one small error in a place neither of us looked at closely. It took me over an hour to figure it out. As usual it's in the last place you'd look. Take a look at my suggestion and see if you agree.
You have to do something with the return value of bfs.
| q = [] | ||
| cur = index | ||
| q << cur | ||
|
|
There was a problem hiding this comment.
I would add the starting point of this BFS' color to compat and then use compat[elem] throughout instead of static colors.
| end | ||
| compat = {} | ||
| dislikes.each_with_index do |neighbors, index| | ||
| bfs(dislikes, compat, index) |
There was a problem hiding this comment.
You are actually not doing anything with the return value for bfs. So... maybe:
Suggested change
| bfs(dislikes, compat, index) | |
| unless bfs(dislikes, compat, index) | |
| return false | |
| end |
| q << elem | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Suggested change
| end | |
| end | |
| return true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Chris, I'm trying to do with with the color method and BFS but it's not working. Can you take a look and leave some comments? Thanks