Sockets - Grace #26

gracemshea · 2019-04-29T05:49:33Z

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	I have a model that returns the works with the top 10 by votes by category.
Describe how you approached testing that model method. What edge cases did you come up with?	When testing in general I generated 10 works and test for them to be present. For edges, I tested that it would return the entire list of work if there were less than 10 or an empty array for no works.
What are `session` and `flash`? What is the difference between them?	Session and flash are hash-like objects that persist through request-response cycle. Session lasts until the user exits the browser (or logs out which essentially sets the user of the session to nil). Flash persists over one cycle and is cleared after the next action.
What was one thing that you gained more clarity on through this assignment?	Validations, Relationships, and Custom Methods in models and model testing.
What is the Heroku URL of your deployed application?	https://grace-media-ranker-app.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	I felt really disorganized on this project. I think it was related to learning things in class and feeling like I was starting aspects of my project over to try and apply that knowledge. A mid-week check in might have been nice, although I'm not sure if others were quite as scattered/challenged as me.

… views and form added

droberts-sea · 2019-05-10T15:47:50Z

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene
Comprehension questions
General
Rails fundamentals (RESTful routing, use of named paths)	yes
Views are well-organized (DRY, use of semantic HTML, use of partials)	yes - good work!
Errors are reported to the user	yes
Business logic lives in the models	yes
Models are thoroughly tested, including relations, validations and any custom logic	yes
Controllers are thoroughly tested, including the login/logout process and multi-step workflows like voting for a work	yes - great work!
Wave 1 - Media
Splash page shows the three media categories	Almost - you have a bug in your `Work.get_media_categories` method
Basic CRUD operations on media are present and functional	yes
Wave 2 - Users and Votes
Users can log in and log out	yes
The ID of the current user is stored in the session	yes
A user cannot vote for the same media more than once	yes
All media lists are ordered by vote count	no
Splash page contains a media spotlight	yes, but see inline
Wave 3 - Users and Votes
Media pages contain lists of voting users	yes, but see inline
Individual user pages and the user list are present	yes
Optional - Styling
Bootstrap is used appropriately	yes
Look and feel is similar to the original	yes
Overall

This is a strong submission. Your implementation matches the demo site very closely, and I would say the learning goals for this assignment were definitely met.

However, there are a number of bugs in this app that were small and straightforward to fix, but which had a devastating effect on the user experience, like not showing any works on the splash or index pages, not displaying the login form, or not being able to upvote or delete from the show page.

What that tells me is that you're relying exclusively on your tests to tell you whether your site works. Your testing on this assignment is really strong, but there were a couple of places where it didn't quite match up with what the user is doing. These are all things that manually running through the workflows of your site would have caught immediately.

The takeaway is, before you submit your next assignment, spend 10 minutes running through it manually and making sure it works!

droberts-sea · 2019-05-10T15:21:04Z

app/views/users/login_form.html.erb

+<% form_with model: @user, url: login_path do |f| %>
+  <div class="form-group">
+    <%= f.label :name %>
+    <%= f.text_field :name, placeholder: "Username", class:"form-control" %>


Line 3 should be a value tag (<%=), otherwise the form won't appear on the page.

droberts-sea · 2019-05-10T15:24:39Z

app/models/work.rb

+  def self.get_media_categories
+    books = self.get_media("books")
+    albums = self.get_media("albums")
+    movies = self.get_media("movies")


Here you search for works with category albums, books and movies, but your database seeds and the dropdown menu on your new work form use the singular version of these (album, book, movie). As a result, your index and splash pages don't display any works.

droberts-sea · 2019-05-10T15:28:11Z

app/views/works/show.html.erb

+    <%= link_to "Edit", edit_work_path(@work.id), class: "btn btn-primary btn-lg" %>
+    <%= link_to "Upvote", class: "btn btn-primary btn-lg" %>
+    <%= link_to "Delete", class: "btn btn-danger btn-lg" %> 
+  </section>


The links on line 13 and 14 are missing URLs, so neither of them works.

droberts-sea · 2019-05-10T15:32:01Z

app/views/homepages/index.html.erb

+<section class="spotlight">
+<% media = Work.all.sample%>
+    <h2 class="spotlight__header">
+        <span class="spotlight__header--prefix"> Media Spotlight </span>


This should probably use the @spotlight variable that you set up in the controller. As-is it shows a random work, not the one with the most votes.

droberts-sea · 2019-05-10T15:32:59Z

app/views/homepages/index.html.erb

+  <section class="top-ten__list-container"> 
+    <h2>Top Movies</h2>
+      <%= render "top_ten", top: @top_ten[2] %>
+  </section>


I love the way you've used a partial to DRY this up - it makes this code much more readable.

droberts-sea · 2019-05-10T15:36:51Z

config/routes.rb

+  get "/", to: "homepages#index"
+  resources :works, only: [:index, :show, :new, :create, :edit, :update, :destroy]
+  resources :works do
+    resources :votes, only: [:create]


This code is a little redundant:

On line 6, you limit resources to generate "only" all 7 of the RESTful routes

On line 7, you re-generate all 7 routes again

The change here would be to omit line 6.

droberts-sea · 2019-05-10T15:37:05Z

config/routes.rb

+  post "/login", to: "users#login"
+  get "/users/current", to: "users#current", as: "current_user"
+
+  resources :users, only: [:index, :show]


Good work generating only the routes your application needs.

droberts-sea · 2019-05-10T15:37:54Z

app/models/vote.rb

+class Vote < ApplicationRecord
+  belongs_to :user
+  belongs_to :work
+  validates :user, uniqueness: { scope: [:work], message: "has already voted for this work" }


Good work getting this tricky uniqueness scope figured out!

droberts-sea · 2019-05-10T15:38:10Z

app/models/work.rb

+  def self.top_media
+    top_works = get_media_categories.map do |category|
+      category[0..9]
+    end


I love the way the methods in this file build on each other, each providing a small bit of functionality. This is an excellent example of functional decomposition.

droberts-sea · 2019-05-10T15:40:01Z

test/controllers/users_controller_test.rb

+
+    it "will create an account for and login a new user" do
+      @login_data[:user][:name] = "new user"
+


Good work catching the two different success cases here.

Is there a failure case? What if the user forgets to type in their name before logging in?

gracemshea added 29 commits April 22, 2019 14:46

Initial Rails setup

7d87af8

created work model, works.yml, and work_test.rb and set up seed.rb

7d2c9ca

generated work user and vote models. seeded db

8d76c13

generated model tests and controllers

bfdbaa1

database reset

63e6658

reseeded db

236e983

index page lists works by category

2efad3b

sample 10 works in each category added to work model

09a4f07

homepages controller added and main code for index.html.erb

514b6df

main code for homepages index.html.erb

a761107

added new create show and strong params to works_controller. new work…

3ad5be1

… views and form added

CRUD operations

e3f44c8

trying to figure out yaml error

c9ad26c

login method added to user controller

0cf6ae5

refinement to login method

dca21c5

top ten method

ba996b5

added styling, views, html tags, refinement to sectioning.

37f38a7

styling tweak

46006dd

gemfile updated

e58672d

styling and tags refined

8623db3

refinement

d410eab

model testing relationships

baf01b3

user and votes controller tests

801d63f

edited works.yml but still issues in testing

a5afb74

tidy up homepages controller

9a4019f

refinement to user index and login views

8dc5a7b

refinement to new and edit work views

804aaf2

works helper added

0ded559

styling closer, but still need to tidy up the view all works page.

cc53860

gracemshea marked this pull request as ready for review April 29, 2019 14:44

gracemshea and others added 19 commits April 29, 2019 14:14

thanks to chris and devin I am not truly debugging

aee2639

refactoring models

903d039

refactoring controllers

bfb1edb

remove helper method for time being

5801628

reworking tests and added partial view for homepage

7631c8d

application.html.erb tidying alert message

401d9a1

refactoring work form view

1ab0e1c

helpers added to test helper

ef8e909

caught a big bug

52763cd

view for work index redone

a1af5c8

Update README.md

cb91929

changes to user_test.rb. stopping point in debugging

9eeda46

Merge branch 'master' of https://github.com/gracemshea/MediaRanker

e235faf

votes controller issues

2e7966b

debugging

9b1563c

stopping point on debugging

0e7323d

corrected votes.yml files and migrated value column

875fd07

debugging continues

9a821ba

stopping point

fbbe8e7

droberts-sea reviewed May 10, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sockets - Grace #26

Sockets - Grace #26

Uh oh!

gracemshea commented Apr 29, 2019 •

edited

Loading

Uh oh!

droberts-sea commented May 10, 2019

Uh oh!

droberts-sea May 10, 2019

Uh oh!

droberts-sea May 10, 2019

Uh oh!

droberts-sea May 10, 2019

Uh oh!

droberts-sea May 10, 2019

Uh oh!

droberts-sea May 10, 2019

Uh oh!

droberts-sea May 10, 2019

Uh oh!

droberts-sea May 10, 2019

Uh oh!

droberts-sea May 10, 2019

Uh oh!

droberts-sea May 10, 2019

Uh oh!

droberts-sea May 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		it "will create an account for and login a new user" do
		@login_data[:user][:name] = "new user"

Sockets - Grace #26

Are you sure you want to change the base?

Sockets - Grace #26

Uh oh!

Conversation

gracemshea commented Apr 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Media Ranker

Comprehension Questions

Uh oh!

droberts-sea commented May 10, 2019

Media Ranker

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gracemshea commented Apr 29, 2019 •

edited

Loading