Skip to content

Conversation

@minams
Copy link

@minams minams commented Apr 29, 2019

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a custom model method you wrote.
Describe how you approached testing that model method. What edge cases did you come up with?
What are session and flash? What is the difference between them?
What was one thing that you gained more clarity on through this assignment?
What is the Heroku URL of your deployed application? https://mediarank.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?

@CheezItMan
Copy link

Media Ranker

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Very few commits, good commit messages
Comprehension questions MISSING
General
Rails fundamentals (RESTful routing, use of named paths) Only works controller routes, and homepage
Views are well-organized (DRY, use of semantic HTML, use of partials) Semantic HTML, but few actions finished
Errors are reported to the user Some attempts have been made, but no flash notices displayed
Business logic lives in the models You had it started
Models are thoroughly tested, including relations, validations and any custom logic Some tests written, but unfinished, you had a good start on the business logic testing
Controllers are thoroughly tested, including the login/logout process and multi-step workflows like voting for a work
Wave 1 - Media
Splash page shows the three media categories Check
Basic CRUD operations on media are present and functional You have index and show, new and create actions working, others are not
Wave 2 - Users and Votes
Users can log in and log out NOPE
The ID of the current user is stored in the session NOPE
A user cannot vote for the same media more than once NOPE
All media lists are ordered by vote count NOPE
Splash page contains a media spotlight NOPE
Wave 3 - Users and Votes
Media pages contain lists of voting users NOPE
Individual user pages and the user list are present NOPE
Optional - Styling
Bootstrap is used appropriately NOPE
Look and feel is similar to the original NOPE
Overall You had a lot of things going on last week, and you didn't finish. See what you can do this week on bEtsy, and focus on making sure you're testing the action you create throughly. Let me know what questions you have.

def edit
end

def delete

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method should be named destroy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants