Ports - Jillianne #35
Conversation
Media RankerWhat We're Looking For
Jillianne! We talked through this project submission briefly, and it continues to be true; in so many ways, there are parts of this project that have all of the features and show the learning goals, just incomplete:
These were the incomplete features:
I've added some comments on things to move forward with concretely That being said, I super understand that a lot of this is because of missing 2.5 days of class and having much less project time. All that said, well done-- I'm marking this project as "approaches standard" because of its level of consistent completeness, but you got through the most interesting parts of functionality. Please let me know if there are questions on content comprehension |
|
|
||
| def homepage | ||
| @works = Work.all | ||
| @ranked_works = @works.order(:id) |
There was a problem hiding this comment.
Ordering by id :( If you had to sort it a different way, what would you do?
|
|
||
|
|
||
| </tr> | ||
| <% @works.where(category: "album").each do |work| %> |
There was a problem hiding this comment.
it might be better form to establish @albums = @works.where(category: "album") in your controller action rather than place this logic in the view, and then use @albums
| <th>Title</th> | ||
| <th>Created By</th> | ||
| <th>Published</th> | ||
| <th>Upvote</th> |
| @@ -0,0 +1,7 @@ | |||
| Media Spotlight: <%= @ranked_works.first.title %> by <%= @ranked_works.first.created_by %> <br> | |||
| <%#= @ranked_works.first.votes %> - <%= @ranked_works.first.description %> <%# will be order by vote count next %> <br><br> | |||
| <p>Top Movies: <%= @ranked_works.where(category: "movie")[0..10] %></p> | |||
There was a problem hiding this comment.
Mentioned this in a different file, but it may be better to move the logic that defines this set of works in the controller action, like @top_movies = @ranked_works.where(category: "movie")[0..10]. We'll want to keep complex logic like this out of the view
| @@ -0,0 +1,7 @@ | |||
| Media Spotlight: <%= @ranked_works.first.title %> by <%= @ranked_works.first.created_by %> <br> | |||
2 participants
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?