ports - sav #36
Open
ports - sav #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Media RankerWhat We're Looking For
|
CheezItMan
reviewed
May 7, 2019
| end | ||
|
|
||
| describe "relations" do | ||
| it "will have 0 votes" do |
There was a problem hiding this comment.
probably should be it "can have 0 votes" do
| belongs_to :user | ||
| belongs_to :work | ||
|
|
||
| validates :user, presence: true, uniqueness: { scope: [:work] } |
| render :login_form, status: :bad_request | ||
| end | ||
| end | ||
| if @user.valid? |
There was a problem hiding this comment.
This if statement seems a little extra, maybe if you had an earlier return when the user isn't valid you wouldn't need this if.
| @@ -0,0 +1,22 @@ | |||
| class VotesController < ApplicationController | |||
| def create | |||
There was a problem hiding this comment.
Take a look at how big this method is. I suggest creating a method upvote on the work or user model. That might help you simplify this method a bit.
| @@ -0,0 +1,70 @@ | |||
| class WorksController < ApplicationController | |||
| before_action :find_work, except: [:index, :new, :create] | |||
| @work.destroy | ||
| redirect_to root_path | ||
| else | ||
| head :not_found |
There was a problem hiding this comment.
Maybe instead of head now we should do a redirect with an error message to the user with flash.
| let(:user) { users(:three) } | ||
| let(:work) { works(:one) } | ||
| describe "Votes#create" do | ||
| it "will create a vote if logged in" do |
There was a problem hiding this comment.
You need a test for the action if they're not logged in, and a test for a duplicate vote
| category: "book", | ||
| id: work.id } } | ||
| expect { | ||
| post works_path, params: work_param |
There was a problem hiding this comment.
Wait a minute! this is a post request not a patch!!!!!!
| id: work.id } } | ||
| expect { | ||
| post works_path, params: work_param | ||
| }.must_change "Work.count", 1 |
There was a problem hiding this comment.
Also update shouldn't be changing the count of works!
making changes to test travis ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?