Sockets - Shirley

[shirley1chu]

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	The top ten method, which returns the top 10 most voted works and takes the media category as a parameter.
Describe how you approached testing that model method. What edge cases did you come up with?	If there are less than 10 works in the collection.
What are session and flash? What is the difference between them?	Session lasts for as long as the user is on the browser. Flash lasts for one request-response cycle.
What was one thing that you gained more clarity on through this assignment?	Fixtures and make tests that involve login.
What is the Heroku URL of your deployed application?	https://shirley-media-ranker.herokuapp.com/works
Do you have any recommendations on how we could improve this project for the next cohort?

[dHelmgren]

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	yes
Comprehension questions	yes
General
Rails fundamentals (RESTful routing, use of named paths)	Yes
Views are well-organized (DRY, use of semantic HTML, use of partials)	yes, but see comments on partials
Errors are reported to the user	yes
Business logic lives in the models	yes
Models are thoroughly tested, including relations, validations and any custom logic	yes
Controllers are thoroughly tested, including the login/logout process and multi-step workflows like voting for a work	yes
Wave 1 - Media
Splash page shows the three media categories	yes
Basic CRUD operations on media are present and functional	yes
Wave 2 - Users and Votes
Users can log in and log out	yes
The ID of the current user is stored in the session	yes
A user cannot vote for the same media more than once	yes
All media lists are ordered by vote count	No, your all media page isn't sorted.
Splash page contains a media spotlight	yes
Wave 3 - Users and Votes
Media pages contain lists of voting users	yes
Individual user pages and the user list are present	yes
Optional - Styling
Bootstrap is used appropriately	yes
Look and feel is similar to the original	yes
Overall	Great work overall, I've highlighted a couple of spots where you could stand to better leverage view partials. Solid submission, meets the learning goals etc.

[dHelmgren]

You repeat this work 3 times. Seems like a good opportunity to use a view partial!

[dHelmgren]

Again, a great candidate for a view partial!