Ports - Ngoc #43

lebaongoc · 2019-04-29T20:45:08Z

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	I wrote a custom method called "find_top_ten" in the Work model to return an array of 10 works for a particular category(book, album, or movie) and that array is sorted by the number of votes.
Describe how you approached testing that model method. What edge cases did you come up with?	I started with generating 11 works in the yml file to use as the test database. After that I started with the output of the "find_top_ten" custom method and wrote test to verify that the method return an array with 10 items. One edge case that I came up with is when the work in a particular category(book) does not exist, I would expect the method return an empty array as output.
What are `session` and `flash`? What is the difference between them?	Session is similar to flash, it's a hash that stores key, value pairs of info that could be used to track a user or display a message to a user. The different is in how long the info lasts. Session hash last until the user closes a browser or log out while flash only last until the next request.
What was one thing that you gained more clarity on through this assignment?	I gained more clarify on how session hash works , how are the different models linked together with the foreign key and the methods available after ActiveRecord relationships were established
What is the Heroku URL of your deployed application?	https://ngoc-media-ranker.herokuapp.com/
https://trello.com/b/aXbTcPwK/media-ranker-week-11
Do you have any recommendations on how we could improve this project for the next cohort?	I would find a more guidance of the custom model to display top-ten media helpful.

…abase

…controller test file

…test

… method

…helper

…lication

CheezItMan · 2019-05-03T22:12:24Z

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good number of commits and good commit messages. I will say however that `debugged` isn't very informative as a commit message.
Comprehension questions	Check, for the custom model methods, I would take a look at the submissions from Steph or Sav and see how they did them. You can definitely take a look after the project is submitted
General
Rails fundamentals (RESTful routing, use of named paths)	Check
Views are well-organized (DRY, use of semantic HTML, use of partials)	Check
Errors are reported to the user	Check
Business logic lives in the models	Check, but see my notes
Models are thoroughly tested, including relations, validations and any custom logic	Check, see my inline notes for specific feedback here
Controllers are thoroughly tested, including the login/logout process and multi-step workflows like voting for a work	Check, see my
Wave 1 - Media
Splash page shows the three media categories	Check
Basic CRUD operations on media are present and functional	Check
Wave 2 - Users and Votes
Users can log in and log out	Check
The ID of the current user is stored in the session	Check
A user cannot vote for the same media more than once	Check
All media lists are ordered by vote count	Check
Splash page contains a media spotlight	Check
Wave 3 - Users and Votes
Media pages contain lists of voting users	Check
Individual user pages and the user list are present	Check
Optional - Styling
Bootstrap is used appropriately	Check
Look and feel is similar to the original	Check, nice work!
Overall	This was very well done! Great work. You hit all the learning goals. It's not perfect, but take a look at my inline feedback and let me know what questions you have.

CheezItMan · 2019-05-03T16:19:29Z

test/controllers/works_controller_test.rb

+      album.destroy
+
+      # Act
+      get work_path(invalid_album_id)


This test is failing

CheezItMan · 2019-05-03T16:20:02Z

app/controllers/works_controller.rb

+  end
+
+  def show
+    @votes = @work.votes.order(created_at: :desc)


You need to check to see if you could not find @work.

CheezItMan · 2019-05-03T18:48:47Z

test/controllers/votes_controller_test.rb

+require "test_helper"
+
+describe VotesController do
+  before do


Nice use of a before block

CheezItMan · 2019-05-03T18:49:12Z

test/controllers/votes_controller_test.rb

+      post work_votes_path(@work.id)
+    }.must_change "Vote.count", 1
+
+    expect(flash[:success]).must_equal "Successfully upvoted!"


You should also test redirection

CheezItMan · 2019-05-03T18:50:46Z

test/controllers/works_controller_test.rb

+      expect(album_to_update.creator).must_equal @input_creator
+      expect(album_to_update.publication_year).must_equal @input_publication_year
+      expect(album_to_update.description).must_equal @input_description
+      must_respond_with :redirect


You should also test where they redirect to.

CheezItMan · 2019-05-03T18:52:36Z

test/models/vote_test.rb

@@ -0,0 +1,4 @@
+require "test_helper"
+


no validations for votes? You could make one to require a unique combination of user-work.

CheezItMan · 2019-05-03T18:53:14Z

app/models/work.rb

+  def self.find_most_voted
+    max_votes = 0
+    most_voted = nil
+    Work.all.each do |work|


You could do this with .order or .sort_by instead

CheezItMan · 2019-05-03T18:57:18Z

test/models/work_test.rb

+    let(:books) { Work.where(category: "book") }
+
+    it "should return a list of works that belong to book category" do
+      expect(Work.find_top_ten("book")).must_be_kind_of Array


You should also verify that each element is a Work and is in the right category.

CheezItMan · 2019-05-03T18:57:43Z

test/models/work_test.rb

+    end
+
+    it "should return an empty list if no books exist" do
+      books.each do |book|


There is also a destroy_all method.

CheezItMan · 2019-05-03T21:59:15Z

app/controllers/votes_controller.rb

@@ -0,0 +1,30 @@
+class VotesController < ApplicationController
+  def create
+    if session[:user_id]


There's a lot of business logic here, I suggest moving some of it to the Work model so you could just call: work.upvote(user). You could also put the upvote method in the User model

added use travis CI to the readme file

lebaongoc added 30 commits April 22, 2019 16:44

create new media rank rails application

bbda837

created seed.rb file and imported data from the csv file into the dat…

5820ef2

…abase

created navigation bar

e4c3f5c

debugged show method & wrote test for index and show method in works …

4fc05d0

…controller test file

created homepage controller

677d683

added homepage controller, homepage view file, homepage index method …

b6a0698

…test

built new and create methods in work controller, wrote tests for both…

59cde41

… method

added validation test works model

8c7c0a4

created edit and update methods in works controller

9f8a4c0

added edit method and test

f6544fe

added delete method and test

a9bdda3

created users controller

29c4a04

created user controller, model, login and logout method, adding test …

6ce1e6d

…helper

created user controller, login and logout method and test

46ad93d

created vote model

ec5339c

created vote model and add dependency on Users and Works

68363e8

added Votes controller

0159fcd

added index, show method to users controller and their routes

43e4fe9

added index and show view file, update routes, and button link in app…

cc87bdb

…lication

debugged

23836be

added test for user controller and model, update test for work model

01d7d29

added test to vote model

0a47c65

added find_most_voted and find_top_ten methods to work model

f646eff

added work model test

8fa9725

added tests for work model

0181b91

update application login, logout

7c828b2

debugged

92a39d3

debugged

f5e655c

updated application.html.erb format

d381218

debugged

c33d730

lebaongoc added 9 commits April 29, 2019 16:26

debugged

e4fc945

updated homepage index styling

e884f00

added main section to application.html.erb

5acc81d

added styling for works index file

09d1287

updated partial form

9dfefe7

updated works-show styling

34e5253

added styling for users#index

ce51762

added styling for users#show

94509c1

added owl to title bar

6d7b06a

CheezItMan reviewed May 3, 2019

View reviewed changes

lebaongoc and others added 5 commits May 15, 2019 10:49

updated works controller to fix show method to account for @work = nil

1bdb5ab

added travis yml file

0aecafe

modify yml file

3f9f16c

added use travis CI to the readme file

87aed1a

Merge pull request #1 from lebaongoc/travis-test

c1507ca

added use travis CI to the readme file

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ports - Ngoc #43

Ports - Ngoc #43

Uh oh!

lebaongoc commented Apr 29, 2019

Uh oh!

CheezItMan commented May 3, 2019

Uh oh!

CheezItMan May 3, 2019

Uh oh!

CheezItMan May 3, 2019

Uh oh!

CheezItMan May 3, 2019

Uh oh!

CheezItMan May 3, 2019

Uh oh!

CheezItMan May 3, 2019

Uh oh!

CheezItMan May 3, 2019

Uh oh!

CheezItMan May 3, 2019

Uh oh!

CheezItMan May 3, 2019

Uh oh!

CheezItMan May 3, 2019

Uh oh!

CheezItMan May 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Ports - Ngoc #43

Are you sure you want to change the base?

Ports - Ngoc #43

Uh oh!

Conversation

lebaongoc commented Apr 29, 2019

Media Ranker

Comprehension Questions

Uh oh!

CheezItMan commented May 3, 2019

Media Ranker

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants