Ports - Kate by goblineer · Pull Request #44 · Ada-C11/MediaRanker

goblineer · 2019-04-30T16:33:30Z

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	The methods that create the front-page content (top ten lists, spotlight media, etc.) are all custom methods of the Works model. I created them to sort the data so that views could pull up the pre-sorted lists.
Describe how you approached testing that model method. What edge cases did you come up with?
What are `session` and `flash`? What is the difference between them?	Session is used to save information over a users session keeping track of activity once logged in through cookies. Flash is a one time message shown to the users telling the user something happened. It is also a way to display error messages.
--
What was one thing that you gained more clarity on through this assignment?	I'm starting to "see" the RESTful routes much more instinctively. By the end of the project, I could see some wacky design choices I'd made at the beginning of the project, which tells me that I had a few big a-ha moments along the way.
What is the Heroku URL of your deployed application?	http://mediaranks.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?

CheezItMan · 2019-05-02T17:28:27Z

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good number of commits and commit messages
Comprehension questions	Check, I'm glad you have a better understanding of RESTful routes. There are some questions unanswered
General
Rails fundamentals (RESTful routing, use of named paths)	Check
Views are well-organized (DRY, use of semantic HTML, use of partials)	Check
Errors are reported to the user	Check
Business logic lives in the models	Check
Models are thoroughly tested, including relations, validations and any custom logic	NOPE
Controllers are thoroughly tested, including the login/logout process and multi-step workflows like voting for a work	NOPE
Wave 1 - Media
Splash page shows the three media categories	Check
Basic CRUD operations on media are present and functional	Check
Wave 2 - Users and Votes
Users can log in and log out	Check
The ID of the current user is stored in the session	Check
A user cannot vote for the same media more than once	Can't vote!
All media lists are ordered by vote count	Check
Splash page contains a media spotlight	Check
Wave 3 - Users and Votes
Media pages contain lists of voting users	Check
Individual user pages and the user list are present	Check
Optional - Styling
Bootstrap is used appropriately	Check, nice!
Look and feel is similar to the original	Check
Overall	Not bad, not perfect either. Things to work on include the upvote and working to improve testing. Check out my inline comments and let me know any questions you have.

CheezItMan

Not bad, not perfect, but mostly working. Things to improve: Testing in all categories. Some things seem broken on Heroku.

CheezItMan · 2019-05-01T22:48:21Z

test/controllers/sessions_controller_test.rb

+
+  it "should get logout" do
+    post logout_path
+    must_respond_with :success


This test is failing: Logout should respond with :redirect

You should also test the flash notices.

CheezItMan · 2019-05-01T22:49:53Z

test/controllers/sessions_controller_test.rb

+    get login_path
+    must_respond_with :success
+  end
+


You're missing a test for submitting the login form.

CheezItMan · 2019-05-01T22:50:35Z

test/models/user_test.rb

+  let(:user) { users(:one) }
+
+  describe 'validations' do
+    it 'is valid when all fields are present' do


You should also be testing the reasons the validations fail.

CheezItMan · 2019-05-01T22:51:09Z

test/models/user_test.rb

+    end
+  end
+
+  describe 'has_voted?' do


Good business logic method.

CheezItMan · 2019-05-01T22:53:36Z

test/models/vote_test.rb

+      expect(result).must_equal true
+    end
+
+    it 'requires user_id' do


These validations come with the relationships.

You should however have a validation to ensure that the combination of user_id and work_id is unique.

CheezItMan · 2019-05-02T16:48:06Z

app/controllers/works_controller.rb

@@ -0,0 +1,79 @@
+class WorksController < ApplicationController
+  before_action :find_work, only: [:show, :edit, :update, :destroy, :upvote]


Nice filter!

CheezItMan · 2019-05-02T16:49:05Z

app/controllers/works_controller.rb

+  end
+
+  def update
+    if @work.update(work_params)


You should also check to see if @work.nil just to see if it found that work.

CheezItMan · 2019-05-02T17:17:25Z

app/controllers/works_controller.rb

+  def upvote
+    if @super_user.nil?
+      flash[:warning] = "Please log in so your vote can be counted."
+      redirect_to login_path


For some reason Heroku is crashing here, not sure why. I would also suggest using redirect_back, but I'm not sure why.

CheezItMan · 2019-05-02T17:17:50Z

config/routes.rb

+  post 'works/:id/upvote', to: 'works#upvote', as: 'upvote'
+  resources :works
+
+  resources :users, only: [:index, :show]


CheezItMan · 2019-05-02T17:23:44Z

app/controllers/works_controller.rb

+        flash[:warning] = "Sorry, you can't vote twice on the same work."
+        redirect_back fallback_location: works_path
+      else
+        Vote.create(user_id: @super_user.id, work_id: @work.id)


This is failing because it's complaining about can't write unknown attribute vote_count``

goblineer added 30 commits April 22, 2019 16:41

Initial setup

274abbd

Migrations change data types in tables.

6e0f292

Landing page and test for same

33466c0

Fixes test setup for works controller

6c0b474

Adds basic CSS for landing page and navigation

2fd63b0

Sets up controller for highest ranked on landing page

3c46bcb

Adds spotlight work functionality

26851d2

Matches more CSS with target design

f302083

Adds fixtures for testing

e2c299e

Adds method for vote counting

72873df

Tests for vote model

53f2fd0

Adds table format for works on landing page

2aaa68f

Seeds database with faker content (includes movies)

77ff8f6

Add categories partial view

64b08ea

Add users routes and views on works/index

113d44e

Refactors while I'm waiting for something to load

2423fa3

Adds category partial

f37b08d

Works out top ten method

0d84762

Creates user controller

e0e4a8a

Sets up html views for users

51d950b

Creates (currently empty) methods for user CRUD

746a99c

Adds user model tests

c620dd8

Adds user routes

0253d08

Partial table broke, this reverts to fix

8a37667

Creates sessions controller and associated files

ddd7748

Add the destroy, login, and new views

1121277

Add fixtures for votes tests

c3d5e19

Routes for all sessions methods and upvote added

8787faa

Find user added in private method

bf6b284

Add upvote function, maybe broke the edit/update

7b8a6a2

goblineer added 28 commits April 23, 2019 17:02

Creates necessary methods through models for voting

8097cad

Fixes a few typos, adds sessions methods

987f4a0

Added vote model test

93d5d82

Repairs login form

2ccafb1

Typo fix in works_controller

3ad303f

Honestly just deleted white space

de898a8

Adds correct user_path to flash message

5207888

Creates user index with table of votes/joindate

ca6bc04

Fixes busted sessions routes

4f3c555

Migration for date_voted column in votes table

d956f3d

Dramatically improves works/index with partials!

736d452

This form makes everything work super well!

1ef0228

Edit uses the form!

4863aeb

Adds some data to works fixtures

c762907

Adds login/logout tests and functionality

eabaf6e

hunts for bug

851bde1

Refactors flash messages for readability

87f3a1e

Reroutes user to root_path after deleting an item

5755484

Honestly not sure >_<

37070df

Changes routes to fix login bug

7df1690

Corrects error in logout test route

5f02388

Refactors show method in users

3f95736

Remove vestigial routes

f35c396

Refactor login method, clean up all the things

9c9c543

Shrinkify methods without breaking controller

3b8248a

Add semantic tags and more styling

f9c6448

Front-end changes which were staged for a while.

83cbcb4

Login/logout buttons display correctly

f20d4c3

CheezItMan reviewed May 2, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ports - Kate#44

Ports - Kate#44
goblineer wants to merge 67 commits intoAda-C11:masterfrom
goblineer:master

goblineer commented Apr 30, 2019 •

edited

Loading

Uh oh!

CheezItMan commented May 2, 2019

Uh oh!

CheezItMan left a comment

Uh oh!

CheezItMan May 1, 2019

Uh oh!

CheezItMan May 1, 2019

Uh oh!

CheezItMan May 1, 2019

Uh oh!

CheezItMan May 1, 2019

Uh oh!

CheezItMan May 1, 2019

Uh oh!

CheezItMan May 2, 2019

Uh oh!

CheezItMan May 2, 2019

Uh oh!

CheezItMan May 2, 2019

Uh oh!

CheezItMan May 2, 2019

Uh oh!

CheezItMan May 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1,79 @@
		class WorksController < ApplicationController
		before_action :find_work, only: [:show, :edit, :update, :destroy, :upvote]

Conversation

goblineer commented Apr 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Media Ranker

Comprehension Questions

Uh oh!

CheezItMan commented May 2, 2019

Media Ranker

What We're Looking For

Uh oh!

CheezItMan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

goblineer commented Apr 30, 2019 •

edited

Loading