forked from AdaGold/heaps
-
Notifications
You must be signed in to change notification settings - Fork 34
Jessica #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jessicacaley
wants to merge
3
commits into
Ada-C11:master
Choose a base branch
from
jessicacaley:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Jessica #3
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,18 +14,23 @@ def initialize | |
| end | ||
|
|
||
| # This method adds a HeapNode instance to the heap | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(n(log(n))) where n is the number of nodes in the heap | ||
| # Space Complexity: O(1) | ||
| def add(key, value = key) | ||
| raise NotImplementedError, "Method not implemented yet..." | ||
| heap_node = HeapNode.new(key, value) | ||
| @store << heap_node | ||
| heap_up(@store.length - 1) | ||
| end | ||
|
|
||
| # This method removes and returns an element from the heap | ||
| # maintaining the heap structure | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(logn) where n is the number of elements in the heap | ||
| # Space Complexity: O(1) | ||
| def remove() | ||
| raise NotImplementedError, "Method not implemented yet..." | ||
| swap(0, @store.length - 1) | ||
| removed = @store.pop | ||
| heap_down(0) | ||
| return removed.value | ||
| end | ||
|
|
||
|
|
||
|
|
@@ -55,17 +60,41 @@ def empty? | |
| # This helper method takes an index and | ||
| # moves it up the heap, if it is less than it's parent node. | ||
| # It could be **very** helpful for the add method. | ||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(logn) where n is the number of nodes in the tree | ||
| # Space complexity: O(1) | ||
| def heap_up(index) | ||
| return if index == 0 | ||
| current_index = index | ||
| parent_index = (index - 1) / 2 | ||
|
|
||
| return if @store[current_index].key > @store[parent_index].key | ||
|
|
||
| swap(current_index, parent_index) | ||
| heap_up(parent_index) | ||
| end | ||
|
|
||
| # This helper method takes an index and | ||
| # moves it up the heap if it's smaller | ||
| # than it's parent node. | ||
| def heap_down(index) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nicely done! |
||
| raise NotImplementedError, "Method not implemented yet..." | ||
| current_index = index | ||
| left_child_index = index * 2 + 1 | ||
| right_child_index = index * 2 + 2 | ||
|
|
||
| return unless @store[left_child_index] # we're at the bottom of the tree (could also use length) | ||
|
|
||
| if @store[right_child_index] | ||
| if @store[left_child_index].key < @store[right_child_index].key | ||
| swap(current_index, left_child_index) | ||
| heap_down(left_child_index) | ||
| else | ||
| swap(current_index, right_child_index) | ||
| heap_down(right_child_index) | ||
| end | ||
| else | ||
| swap(current_index, left_child_index) | ||
| return | ||
| end | ||
| end | ||
|
|
||
| # If you want a swap method... you're welcome | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are making at most
log nswaps to add something to a heap, the time complexity is O(log n)