Open
Conversation
CheezItMan
reviewed
Sep 17, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Overall nice work. There are some issues with the Queue and the circular buffer. Take a look at my notes and let me know what questions you have.
| @@ -1,7 +1,25 @@ | |||
| require_relative './stack.rb' | |||
|
|
|||
| def balanced(string) | |||
|
|
||
| def dequeue | ||
| raise NotImplementedError, "Not yet implemented" | ||
| if @front == @rear |
There was a problem hiding this comment.
You first need to check to see if front and rear are both -1, if so, then the queue is empty, and you should raise an error.
Otherwise if front == rear then the queue is full.
|
|
||
| def empty? | ||
| raise NotImplementedError, "Not yet implemented" | ||
| if @store[@front...@rear].length == 0 |
There was a problem hiding this comment.
What if the rear has wrapped around the buffer and is now less than the front?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation