Open
Conversation
CheezItMan
reviewed
Sep 10, 2019
CheezItMan
left a comment
There was a problem hiding this comment.
You don't have the postfix problem done, but overall not bad. You do have some issues with the circular buffer. Take a look at my comments and let me know if you have questions.
|
|
||
| def balanced(string) | ||
| raise NotImplementedError, "Not implemented yet" | ||
| return false if string.length % 2 != 0 |
| def dequeue # remove from front | ||
| removed = @store[@front] | ||
| @store[@front] = nil | ||
| self.size == 0 ? @front = -1 : @front += 1 |
There was a problem hiding this comment.
What about the front wrapping around the array. Instead of @front +=1 you should have @front = (@front + 1) % QUEUE_SIZE
| def size | ||
| raise NotImplementedError, "Not yet implemented" | ||
| size = 0 | ||
| @store.each do |val| |
There was a problem hiding this comment.
This is less efficient than starting at @front and progressing through the array until you reach @rear, or keeping an instance variable for size.
| return @store.to_s | ||
| def to_string | ||
| formatted_array = [] | ||
| @store.each do |x| |
There was a problem hiding this comment.
This assumes @front < @rear, that's not always going to be true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation