Skip to content

Sockets - Kirsten #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kanderson38 wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Sockets - Kirsten #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9f7b2ab
add css files
kanderson38 Apr 3, 2019
4184ec5
formatted intro, why and quote
kanderson38 Apr 3, 2019
31dc134
formatted footer
kanderson38 Apr 3, 2019
e9be3a2
starting to format #tram
kanderson38 Apr 4, 2019
21b92cd
staggered team images and text properly
kanderson38 Apr 4, 2019
5e60ddb
finished formatting sponsors, added google font
kanderson38 Apr 5, 2019
0e6953f
Messed with blockquote
kanderson38 Apr 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,34 +3,37 @@
<head>
<meta charset="utf-8">
<title>Startrly</title>
<link rel="stylesheet" type="text/css" href="normalize.css">
<link rel="stylesheet" type="text/css" href="styles.css">
<link href="https://fonts.googleapis.com/css?family=Fredoka+One" rel="stylesheet">
</head>
<body>
<div>
<div class="container">
Copy link

@goblineer goblineer Apr 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, whole page in a container -- maybe a good place for a huuuuge grid to help with layout (with which you don't need more help, as your layout looks pixel-perfect). Do you style this class anywhere?



<nav>
<ul>
<li>
Startrly
</li>
<li>
<li id="trynow">
Try Now!
</li>
<li>
<li id="about">
About
</li>
</ul>
</nav>


<section>
<section id="intro">
<h1>Startrly</h1>
<sub>A catchy tagline for a great solution</sub>
<a href="#">Some Call to Action</a>
</section>


<section>
<section class="quote">
<blockquote>
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
</blockquote>
Expand All @@ -40,7 +43,7 @@ <h1>Startrly</h1>
</section>


<section>
<section id="why">
<h2>Why?</h2>
<ul>
<li>
Expand Down Expand Up @@ -68,7 +71,7 @@ <h2>Why?</h2>
</section>


<section>
<section class="quote">
<blockquote>
Nemo enim ipsam voluptatem quia voluptas sit aspernatur aut odit aut fugit, sed quia consequuntur magni dolores eos qui ratione voluptatem sequi nesciunt.
</blockquote>
Expand All @@ -78,7 +81,7 @@ <h2>Why?</h2>
</section>


<section>
<section id="team">
<h2>Meet the team</h2>
<ul>
<li>
Expand Down Expand Up @@ -110,7 +113,7 @@ <h2>Meet the team</h2>
</section>


<section>
<section id="sponsors">
<h2>Sponsors</h2>
<ul>
<li>
Expand All @@ -132,7 +135,7 @@ <h2>Sponsors</h2>
</section>


<section>
<section id="footer">
<div>
<h3>Support</h3>
<ul>
Copy link

@goblineer goblineer Apr 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HTML is changed only to add ids. Nicely done! ID rather than class is a choice toward specificity but doesn't allow reusing styling in a flexible way. Are there areas where you wrote the same CSS for two different ids?

Expand Down
Loading