Leaves - Samantha

[iamsammysam]

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
What went well in your code style, such as indentation, spacing, variable names, readability, etc.? What was lacking?	I started by including the requirements as comments (pseudocode) and worked from that. Regarding variables I chose simple and short names. I also thought about the user experience by giving a lot of information about the program and feedback. For readability I made "blocks" separated by empty lines of parts of the code that are working on the same data for easy understanding and visualizing.
How did your code keep track of user input?	It stores the user input for "operation" "1st number" and "2nd number" in variables.
How did your code determine what operation to perform?	It took the user input and by using a loop gave an error message until the "operation symbol or word that describes it (including capital letters or uppercase)" input was included at the array "operations" previously created to check this info. If yes the program use the info to do the math.
What opportunities exist to create small methods for this project?	To create a method to get and evaluate user input for the numbers (then the calculator could work later with more than 2 numbers without adding to much code to it) also to create a method for the math operations.
In the next project, what would you change about your process? What would you keep doing?	I usually start by designing the program in a simple way that works and after that I use methods and interpolation to make it work with less code. A next step for me will be to create my own methods, use more REGEX and other tools to make the program smaller but still effective.

[beccaelenzil]

Great work incorporating methods to write clean and concise code. Your answers to the reflection questions are thorough and thoughtful. See the code review for minor suggestions for DRYing up your code and simplifying some conditional control structures.

[beccaelenzil]

You've written almost exactly the same code here twice, to get the first number and the second number. Could you DRY that up by putting this logic in a method and/or a loop?

[beccaelenzil]

Consider using a case/when block to simplify your code.

[beccaelenzil]

This is a clever way to check for valid user input

[beccaelenzil]

Using while and include? is a great way to check for valid user input.

[beccaelenzil]

Calculator

What We're Looking For

Feature	Feedback
Readable code with consistent indentation	yes
Practices using variables appropriately	yes
Practices using conditionals appropriately	yes
If any, practices iteration appropriately	yes
If any, practices using custom methods appropriately	yes
Takes in two numbers and an operator and can perform addition	yes
Takes in two numbers and an operator and can perform subtraction	yes
The program handles divide when attempting to divide by zero	yes