Leaves - Nicky

[njch5]

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
What went well in your code style, such as indentation, spacing, variable names, readability, etc.? What was lacking?	Indentation and spacing makes the calculator file readable and variables names are explicitly clear. What I thought was lacking was for the variable names within the methods, I thought it may be difficult to differentiate between the two variable names (num_one and num_two) especially when they're all the same amongst all the calculation methods.
How did your code keep track of user input?	For the operators, I nested case/when statements within a while loop to say if any of the appropriate operators are entered then it would be stored as the user's operator within the variable 'users_operator'. If not, then a message is printed to prompt the user for a valid operator. The message will continue to loop until the user enters a valid input. For user's number inputs, I used begin/rescue/retry statements which will throw an exception if a user does not enter a valid integer input. I was not able to also check for a float input so I was wondering if that would require additional conditional statements?
How did your code determine what operation to perform?	Based on what was stored in the users_operator variable, the series of conditional statements toward the bottom of my code will then determine which method to use for calculations.
What opportunities exist to create small methods for this project?	A small method for check for division by zero. Another method for validating user input for numbers.
In the next project, what would you change about your process? What would you keep doing?	I would first organize what I'm trying to achieve at a higher level by using pseudocode to break each requirement down in simpler terms so it's easier to comprehend the project objectives. I would continue writing out the variables I need and determine what loops can be used.

[beccaelenzil]

Your code is clear and makes good use of new concepts (methods, case/when). You have several clever solutions to dealing with invalid user input. See code review for a few minor suggestions on how to make your code more concise.

[beccaelenzil]

Instead of Interger(gets.chomp) you could use Float(gets.chomp). Converting to Floats is a better option so that it performs division correctly (5/2 = 2.5 (as opposed to 2).)

[beccaelenzil]

Consider using a loop to DRY up your code.

[beccaelenzil]

The is a clever use of begin/rescue/retry. Nice research!

[beccaelenzil]

Consider using a case/when block to simplify your code.

[beccaelenzil]

This is clever -- however an includes? method would simplify this operation:

until [array of valid operations].includes?(users_operator)

[beccaelenzil]

Calculator

What We're Looking For

Feature	Feedback
Readable code with consistent indentation	yes
Practices using variables appropriately	yes
Practices using conditionals appropriately	yes
If any, practices iteration appropriately	yes
If any, practices using custom methods appropriately	yes
Takes in two numbers and an operator and can perform addition	yes
Takes in two numbers and an operator and can perform subtraction	yes
The program handles divide when attempting to divide by zero	yes