Conversation
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work, you hit the basic learning goals here. I do think you missed one edge-case on heapDown, but otherwise very well done.
| // Time Complexity: O(n log n) - first iterate over list (O(n)) | ||
| // and run .add() for each item (O(log n)) | ||
| // Space Complexity: O(1) - uses original list param to store sorted list | ||
| function heapsort(list) { |
There was a problem hiding this comment.
👍 , except that you're building a heap, so the space complexity is O(n).
| // Time Complexity: O(log n) | ||
| // Space Complexity: O(log n) | ||
| add(key, value = key) { |
There was a problem hiding this comment.
The method works, and you have the space complexity right because you're doing recursion.
| // Time complexity: O(1) | ||
| // Space complexity: O(1) | ||
| isEmpty() { |
| const leftChild = 2 * index + 1; | ||
| const rightChild = 2 * index + 2; | ||
|
|
||
| if (leftChild >= this.store.length || rightChild >= this.store.length) return; |
There was a problem hiding this comment.
What if the left child is smaller than the length and the left child is smaller than it's parent, and at the same time the right child is equal to the length?
There was a problem hiding this comment.
@CheezItMan can you give me an example? I'm having a hard time thinking of how a child index would be smaller than its parent index.
| // This helper method takes an index and | ||
| // moves it up the heap if it's smaller | ||
| // than it's parent node. | ||
| heapDown(index) { |
There was a problem hiding this comment.
This method works in most cases, but I think you're missing an edge-case here.
2 participants
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?