Branches - Eve by tofuandeve · Pull Request #34 · Ada-C12/hotel

tofuandeve · 2019-09-09T06:42:19Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What was a design challenge that you encountered on this project?	Deciding what should be a class and what should not. And how much information a class should know
What was a design decision you made that changed over time over the project?	At first, checkin and checkout date were string values, but I decided to change these values to be Date object instead. And I created a Room class which would hold the information of a room number and a list of reservations of itself, but later removed this class as an effort of refactoring my HotelSystem.
What was a concept you gained clarity on, or a learning that you'd like to share?	The dependency of one class on the others in Object Oriented Design. It is important to understand these dependencies in my class, so that I can manage them when ever there is a change to be made inmy design
What is an example of a nominal test that you wrote for this assignment? What makes it a nominal case?	A user of HotelSystem can create a hotel block for valid input (valid date range, valid list of room, valid discount rate)
What is an example of an edge case test that you wrote for this assignment? What makes it an edge case?	A user of HotelSystem cannot create a hotel block for invalid input where a list of room has duplicate/ non-existent room in it
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I spent athe first day to write pseudocode and simplify my pseudocode many times so that my design does the simplest things possible, with the least variables possible. Then I created empty classes with method signatures, then wrote tests for each method so that I can shape each class' behavior. I also started from the simplest class that has the least dependency on other classes (in order: DateRange, Reservation, HotelSystem).

… for it

…m class and add tests

… add tests

…eservation method for HotelSystem class

…r HotelSystem class

…tem class

… and add tests

…ests

…System class

…ons and 0 blocks for nil date input

tildeee · 2019-09-16T14:20:25Z

Hotel

What We're Looking For

Test Inspection

Workflow	yes / yes but no test / no
Wave 1
List rooms	yes
Reserve a room for a given date range	yes
Reserve a room (edge case)	yes
List reservations for a given date	yes
Calculate reservation price	yes
Invalid date range produces an error	yes
Test coverage	yes
Wave 2
View available rooms for a given date range	yes
Reserving a room that is not available produces an error	yes
Test coverage	yes
Wave 3
Create a block of rooms	yes
Check if a block has rooms	yes
Reserve a room from a block	yes
Test coverage	yes

Code Review

Baseline	Feedback
Used git regularly	yes
Answer comprehension questions	yes
Design
Each class is responsible for a single piece of the program	yes
Classes are loosely coupled	yes
Fundamentals
Names variables, classes and modules appropriately	yes
Understanding of variable scope - local vs instance	yes
Can create complex logical structures utilizing variables	yes
Appropriately uses methods to break down tasks into smaller simpler tasks	yes!
Understands the differences between class and instance methods	yes
Appropriately uses iterators and `Enumerable` methods	yes
Appropriately writes and utilizes classes	yes
Appropriately utilizes modules as a namespace	yes
Wrap Up
There is a refactors.txt file	yes
The file provides a roadmap to future changes	yes

Overall Feedback

Great work overall! You've built your first project with minimal starting code. This represents an incredible milestone in your journey, and you should be proud of yourself!

Eve, your submission for this project is fantastic-- your code is clean, intentional, well-thought out, and planned. Your attention to detail (like checking that reservation cost comes back as a formatted string) really shines in this project. Your naming of methods and variables, ease of Enumerables methods, and clean code-style show me how much you know! Also, the way your classes are organized, and your best practices like private helper methods and regular raising of exceptions shows me how much you know about design.

Above all, your tests are amazing! I'm really happy with how well-written your tests are. They cover things accurately and thoroughly, and are so easy to read. I think you did a great job with the tests! I hope you continue to write great tests like this!

I have some small minor suggestions and comments on your code. Also, just as an FYI, about IDs: when we get to Rails, let's see what our strategy will be about giving IDs to objects when we save them in a database! Just something to look forward to :)

Overall, you did a great job on this project. Keep up the great work!

tildeee · 2019-09-16T14:22:15Z

lib/date_range.rb

+      @end_date = input_end_date
+      current_time = Date.today()
+
+      if (@start_date < current_time) || 


Nice touch!

tildeee · 2019-09-16T14:22:53Z

lib/hotel_system.rb

+      blocked_rooms = find_overlapping_rooms_in_hotel_blocks(date_range)
+      available_rooms = @rooms.select do |number| 
+        !has_overlapping(@room_reservation_data[number], date_range) &&
+        !blocked_rooms.include?(number)


This select is clever!

tildeee · 2019-09-16T14:23:19Z

test/hotel_system_test.rb

+      start_date2 = @end_date
+      end_date2 = start_date2 + @duration
+      @hotel_system.make_reservation(start_date2, end_date2)
+      expect (@hotel_system.reservations.length).must_equal @number_of_reservations + 1


Nice case to test!

tildeee · 2019-09-16T14:23:34Z

test/hotel_system_test.rb

+        start_date = Date.parse(start_date_data[index])
+        end_date = Date.parse(end_date_data[index])
+        @hotel_system.make_reservation(start_date, end_date)
+      end


Nice! This is a clean setup step!

tildeee · 2019-09-16T14:23:55Z

test/hotel_system_test.rb

+      end
+    end
+
+    it "returns nil for a nonexistent reservation" do


tildeee · 2019-09-16T14:24:08Z

test/hotel_system_test.rb

+    end
+  end
+
+  describe "available_rooms_in_block method" do


Minor nitpick: This should probably be named something else

oh, I missed this line. It should be "reserve_room for rooms in block"

tofuandeve added 30 commits September 3, 2019 13:53

Verify Setup for Hotel project

0cb10a8

Add tests for DateRange class

8687b6b

Implement DateRange class

445808c

Add HotelSystem class to Hotel module

c8068b1

Add test for Reservation class

c5d74d1

Implement Reservation class

8f2873a

Add @cost as a instance variable to Reservation class and update test…

534f647

… for it

Add .gitignore to Hotel project

143997a

Implement constructor and readers and add tests for HotelSystem class

995c898

Add SimpleCov to test_helper.rb

84c293a

Implement make_reservation and reservation_ids methods for HotelSyste…

d906e6e

…m class and add tests

Fix naming for HotelSystem class

a5d964b

Add create_unique_id to simplify make_reservation for HotelSystem class

ad5ce90

Implement find_reservation_by_date for HotelSystem and add tests

33a7bf1

Implement get_reservation_total_cost method for HotelSystem class and…

c625670

… add tests

Implement .overlap? method for DateRange class and add tests

193e1ad

Add tests for find_available_rooms method and update tests for make_r…

e942693

…eservation method for HotelSystem class

Add find_available_rooms method and update make_reservation method fo…

108868e

…r HotelSystem class

Fix naming warning for get_reservation_total_cost method for HotelSys…

713ef49

…tem class

Refactor HotelSystem class, update make_reservation method and tests

933482f

Implement HotelBlock class and add test

e0ee9ba

Implement create_hotel_block for HotelSystem class and add tests

247d181

Update tests for Reservation class

9417e81

Implement available_rooms_by_hotel_block method for HotelSystem class…

cdef348

… and add tests

Implement reserve_room by room number for HotelSystem class and add t…

3dd3948

…ests

Update Hotel project to use keyword arguments

6e88015

Refactor Hotel project: remove all unnecessary variables out of Hotel…

46e5feb

…System class

Fix date data for test files for Hotel project

7f90d6d

Update tests: remove hardcode data

bed1710

Update test for hotel_block_test.rb

b1c89c0

tofuandeve added 4 commits September 8, 2019 22:44

Update minor naming for hotel_system.rb and hotel_block.rb

b9dd275

Fix bug for find_available_rooms when hotel does not have 0 reservati…

3304f14

…ons and 0 blocks for nil date input

Update indentation for hotel project

8c666d6

Add refactors.txt for hotel project

6c8317c

tildeee reviewed Sep 16, 2019

View reviewed changes

lib/date_range.rb

@end_date = input_end_date

current_time = Date.today()

if (@start_date < current_time) ||

Copy link

tildeee Sep 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch!

tildeee reviewed Sep 16, 2019

View reviewed changes

test/hotel_system_test.rb

end

end

it "returns nil for a nonexistent reservation" do

Copy link

tildeee Sep 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

tildeee reviewed Sep 16, 2019

View reviewed changes

tofuandeve added 6 commits September 30, 2019 00:56

Create CLI for HotelSystem

faaaa69

Update unit tests to be compatible with Minitest 6

450c973

Update HotelSystem#make_reservation to raise appropriate exceptions

9e6b6a3

Update Reservation class to take in room number as argument

650e780

Add CLI for user to interact with HotelSystem

c463113

Fix naming issue for hotel_system_test.rb

11119ac

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Branches - Eve#34

Branches - Eve#34
tofuandeve wants to merge 40 commits intoAda-C12:masterfrom
tofuandeve:master

tofuandeve commented Sep 9, 2019

Uh oh!

tildeee commented Sep 16, 2019

Uh oh!

tildeee Sep 16, 2019

Uh oh!

tildeee Sep 16, 2019

Uh oh!

tildeee Sep 16, 2019

Uh oh!

tildeee Sep 16, 2019

Uh oh!

tildeee Sep 16, 2019

Uh oh!

tildeee Sep 16, 2019

Uh oh!

tofuandeve Sep 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

tofuandeve commented Sep 9, 2019

Hotel

Comprehension Questions

Uh oh!

tildeee commented Sep 16, 2019

Hotel

What We're Looking For

Test Inspection

Code Review

Overall Feedback

Uh oh!

tildeee Sep 16, 2019

Choose a reason for hiding this comment

Uh oh!

tildeee Sep 16, 2019

Choose a reason for hiding this comment

Uh oh!

tildeee Sep 16, 2019

Choose a reason for hiding this comment

Uh oh!

tildeee Sep 16, 2019

Choose a reason for hiding this comment

Uh oh!

tildeee Sep 16, 2019

Choose a reason for hiding this comment

Uh oh!

tildeee Sep 16, 2019

Choose a reason for hiding this comment

Uh oh!

tofuandeve Sep 17, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants