Leaves - Elizabeth by north108 · Pull Request #43 · Ada-C12/hotel

north108 · 2019-09-09T15:53:46Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What was a design challenge that you encountered on this project?	The main challenge was in wave 3. I wanted to use inheritance for hotel_block from reservation but then I realized my reservation used one room to initialize it so I wasn't sure what to do when I needed multiple rooms.
What was a design decision you made that changed over time over the project?	I started by putting methods into reservation but then I realized that almost every method needed to be in the hotel class.
What was a concept you gained clarity on, or a learning that you'd like to share?	Composition. It finally clicked how instance variables can be called in other classes by using composition and how to use that information that I have access to in other classes.
What is an example of a nominal test that you wrote for this assignment? What makes it a nominal case?	I wrote a nominal test for if available_rooms returns an empty array. This is nominal because this is expected behavior for a hotel that has no vacancies.
What is an example of an edge case test that you wrote for this assignment? What makes it an edge case?	Wrote an edge case for if a hotel was initialized with 0 rooms. This is an edge case because we wouldn't expect a hotel to have 0 rooms.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I am proud of myself for almost exclusively writing tests first then code but I didn't utilize pseudocode to its full potential.

…one I created a module called Booking and a class with the corresponding file name. Created test files for each of the classes. Require_relative the test_helper on each test file.

… them as _tests instead of _test. Wrote two tests in hotel_test and wrote the initialize in hotel.rb.

…ts. Wrote make_reservation method and wrote a test. Wrote a sectionn of make_reservation that I will implement later and a corresponding test to use at a later time when I have more of an idea of how the Reservation Class will work. All tests pass.

…Wrote total_nights in DateRange to calculate the reservations total nights. Wrote tests for total_nights. DateRange passes all tests.

…tion_test.rb

… Everything passes.

…ilable. Wrote two tests for it that aren't working properly yet but will be when I integrate available_rooms into make_reservation.

…s available. Wrote a test and passed it.

dHelmgren · 2019-09-16T03:06:39Z

Hotel

What We're Looking For

Test Inspection

Workflow	yes / yes but no test / no
Wave 1
List rooms	yes
Reserve a room for a given date range	yes
Reserve a room (edge case)	no
List reservations for a given date	yes
Calculate reservation price	yes
Invalid date range produces an error	yes
Test coverage	good
Wave 2
View available rooms for a given date range	yes
Reserving a room that is not available produces an error	yes
Test coverage	good
Wave 3	DNF
Create a block of rooms
Check if a block has rooms
Reserve a room from a block
Test coverage

Code Review

Baseline	Feedback
Used git regularly	often and thorough messages! love it
Answer comprehension questions	yes
Design
Each class is responsible for a single piece of the program	no, your `hotel` class does the jobs of other classes.
Classes are loosely coupled	no, due to the above.
Fundamentals
Names variables, classes and modules appropriately	yes
Understanding of variable scope - local vs instance	yes
Can create complex logical structures utilizing variables	yes
Appropriately uses methods to break down tasks into smaller simpler tasks	yes
Understands the differences between class and instance methods	yes
Appropriately uses iterators and `Enumerable` methods	yes
Appropriately writes and utilizes classes	yes
Appropriately utilizes modules as a namespace	yes
Wrap Up
There is a refactors.txt file	yes
The file provides a roadmap to future changes	yes

Overall Feedback

Great work overall! You've built your first project with minimal starting code. This represents an incredible milestone in your journey, and you should be proud of yourself!

I am particularly impressed by the way that you found ways to break down bigger problems into small, readable methods

I do see some room for improvement around delegating methods, and improving your test cases.

dHelmgren · 2019-09-16T02:06:58Z

test/hotel_block_test.rb

this errors out every time. Run a final rake before you commit code! Even if the test isn't complete or doing anything, never check in code that crashes.

dHelmgren · 2019-09-16T02:08:22Z

test/hotel_block_test.rb

room does not exist. This doesn't cause a crash but is a pretty easy-to-fix error

dHelmgren · 2019-09-16T02:11:45Z

lib/hotel.rb

+    def find_reservation(start_date, end_date)
+      reservation_array = []
+      reservations.each do |reservation|
+        if reservation.date_range.start_date == start_date && reservation.date_range.end_date == end_date


this is reaching too far into your reservations and date ranges. This should be cleared up by the POODR chapter 4 discussion.

dHelmgren · 2019-09-16T02:12:46Z

lib/reservation.rb

+      @room = room
+      @total_nights = total_nights
+      @total_cost = total_cost
+    end


If you have a class that has no methods besides initialize, either the class should be a struct of some sort, or some other part of your code is doing its work for it.

dHelmgren · 2019-09-16T02:22:33Z

lib/reservation.rb

@@ -0,0 +1,17 @@
+require_relative 'hotel'


/Users/devin/Documents/Ada/c12/hotel/lib/reservation.rb:1: warning: loading in progress, circular require considered harmful - /Users/devin/Documents/Ada/c12/hotel/lib/hotel.rb

dHelmgren · 2019-09-16T02:22:56Z

lib/room.rb

+
+    attr_reader :number, :cost
+
+    def initialize (number, cost: 200)


This space causes this warning:

/Users/devin/Documents/Ada/c12/hotel/lib/room.rb:6: warning: parentheses after method name is interpreted as an argument list, not a decomposed argument

dHelmgren · 2019-09-16T02:23:20Z

test/hotel_test.rb

+      20.times do 
+        res_start_date = Date.new(2019, 2, 15)
+        res_end_date = Date.new(2019, 2, 20)
+        res = @the_grand_budapest_hotel.make_reservation(res_start_date, res_end_date)


/Users/devin/Documents/Ada/c12/hotel/test/hotel_test.rb:111: warning: assigned but unused variable - res

dHelmgren · 2019-09-16T02:23:55Z

test/reservation_test.rb

/Users/devin/Documents/Ada/c12/hotel/test/reservation_test.rb:11: warning: assigned but unused variable - reservation

dHelmgren · 2019-09-16T02:24:13Z

test/reservation_test.rb

+require 'date'
+
+def build_test_reservation
+  start_date = Date.new(2019, 2, 15)


This seems like you meant it to be a before block.

perhaps a let:

…culator to the reservation class. Fixed tests so everything passes.

north108 added 14 commits September 3, 2019 13:21

Created new files in lib: date_range, hotel, reservation, room. Each …

fa4e0c3

…one I created a module called Booking and a class with the corresponding file name. Created test files for each of the classes. Require_relative the test_helper on each test file.

Fixed require relative statements so now they work.

442414c

Had to rename all of my test files in order to get guard to work. Had…

f611cfa

… them as _tests instead of _test. Wrote two tests in hotel_test and wrote the initialize in hotel.rb.

Refatored make_rooms method to pass first test.

1b14ccb

Refractored make_reservation and make_rooms and edited test to match.

8ac1ac4

Initialized DateRange wrote tests to make sure it created instances. …

e4c0e68

…Wrote total_nights in DateRange to calculate the reservations total nights. Wrote tests for total_nights. DateRange passes all tests.

Refactored Booking::Hotel.make_reservation and refactored the reserva…

543d0a1

…tion_test.rb

Wrote find_reservation method in hotel.rb, wrote corresponding tests.…

ca47db4

… Everything passes.

Checked coverage. At 98% - moving on to wave 2.

4bfa105

Wrote available_rooms method in hotel.rb to check which rooms are ava…

7eeba2a

…ilable. Wrote two tests for it that aren't working properly yet but will be when I integrate available_rooms into make_reservation.

Finished available_rooms to raise an exception when there are no room…

7a05901

…s available. Wrote a test and passed it.

Cleaned up all comments. Offically done with Wave 2.

186cfbb

Created hotel_block class and test file. Didn't get to far on them.

6cd210e

dHelmgren reviewed Sep 16, 2019

View reviewed changes

north108 added 2 commits September 29, 2019 19:33

Added design-activity.

67ec429

Made hotel.rb more single responsibility by moving the total cost cal…

9610cb2

…culator to the reservation class. Fixed tests so everything passes.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Leaves - Elizabeth #43

Leaves - Elizabeth #43
north108 wants to merge 16 commits intoAda-C12:masterfrom
north108:master

north108 commented Sep 9, 2019

Uh oh!

dHelmgren commented Sep 16, 2019

Uh oh!

dHelmgren Sep 16, 2019

Uh oh!

dHelmgren Sep 16, 2019

Uh oh!

dHelmgren Sep 16, 2019

Uh oh!

dHelmgren Sep 16, 2019

Uh oh!

dHelmgren Sep 16, 2019

Uh oh!

dHelmgren Sep 16, 2019

Uh oh!

dHelmgren Sep 16, 2019

Uh oh!

dHelmgren Sep 16, 2019

Uh oh!

dHelmgren Sep 16, 2019

Uh oh!

dHelmgren Sep 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments


		attr_reader :number, :cost

		def initialize (number, cost: 200)

Conversation

north108 commented Sep 9, 2019

Hotel

Comprehension Questions

Uh oh!

dHelmgren commented Sep 16, 2019

Hotel

What We're Looking For

Test Inspection

Code Review

Overall Feedback

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments