Branches-Sara#44
Open
sarashahbaig wants to merge 1 commit intoAda-C12:masterfrom
Open
Conversation
JS AdagramsWhat We're Looking For
|
jmaddox19
reviewed
Nov 27, 2019
| return false; | ||
| } | ||
| }); | ||
| }, |
There was a problem hiding this comment.
There should be a return true; before the end of the function. As is the function is not returning anything if it hasn't already returned false.
Comment on lines
+57
to
+66
| let word = input.toLowerCase().split(""); | ||
| let sameLetters = shuffle(lettersInHand); | ||
|
|
||
| word.forEach(function(letter) { | ||
| if (sameLetters.includes(letter)) { | ||
| let letterLocation = sameLetters.indexOf(letter); | ||
| sameLetters.splice(letterLocation, 1); | ||
| } else { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
I am surprised to realize 2 of the 3 tests still fail when I add the return statement mentioned below. There are several bugs in this code that it'd be good for us to talk about during our 1:1 next week.
|
|
||
| let maxWordScore = 0; | ||
| let maxWord = ""; | ||
| winningWordLetterCount = 0; |
| winningWordLetterCount = 0; | ||
|
|
||
| words.forEach(function(word) { | ||
| if (scoreWord(word) > maxWordScore) { |
There was a problem hiding this comment.
This function doesn't successfully run. Each call to the scoreWord function should be called with Adagrams.scoreWord
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS Adagrams
Congratulations! You're submitting your assignment!
Comprehension Questions