Open
Conversation
Author
|
Added tests for advanced exercises |
CEsGutierrez
changed the title
CheezItMan
reviewed
Feb 23, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work, you hit all the learning goals here. Well done. Take a look at my comments and let me know if you have questions. Your methods pretty much all work, but some could use a bit of refactoring to simplify the methods a bit.
| class Node | ||
| attr_reader :data | ||
| attr_accessor :next | ||
| attr_accessor :prev |
There was a problem hiding this comment.
Nice you're implementing a Doubly Linked List!
| end | ||
| end | ||
|
|
||
| def get_first |
| end | ||
| end | ||
|
|
||
| def length |
Comment on lines
+69
to
+73
| elsif current.next == nil | ||
| current.next = temp | ||
| temp.prev = current | ||
| return | ||
| end |
|
|
||
| end | ||
|
|
||
| def get_last |
| # checks if the linked list has a cycle. A cycle exists if any node in the | ||
| # linked list links to a node already visited. | ||
| # returns true if a cycle is found, false otherwise. | ||
| def has_cycle |
There was a problem hiding this comment.
Nice approach, a bit higher space complexity, but it definitely works!
| # Additional Exercises | ||
| # returns the value in the first node | ||
| # returns nil if the list is empty | ||
| def get_first |
| end | ||
|
|
||
| # method that inserts a given value as a new last node in the linked list | ||
| def add_last(value) |
|
|
||
| # method that returns the value of the last node in the linked list | ||
| # returns nil if the linked list is empty | ||
| def get_last |
|
|
||
| # method to insert a new node with specific data value, assuming the linked | ||
| # list is sorted in ascending order | ||
| def insert_ascending(value) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.