Open
Conversation
| end | ||
|
|
||
| # -the average rating for each driver | ||
| average_rating = 0 |
There was a problem hiding this comment.
You do not need to initialize average_rating since this value is set before you make the comparison.
| total_money_index = money[:cost] | ||
| day_with_most_money = money[:date] | ||
| max_index = total_money_index.rindex(total_money_index.max) | ||
| puts "-Driver ##{money[:id]} has made the most money on #{day_with_most_money[max_index]}." |
There was a problem hiding this comment.
This is a small thing, but make sure your indentation is consistent to promote readability and conform to ruby style guide.
| end | ||
|
|
||
| # -the total amount of money each driver has made | ||
| total_money = 0 |
There was a problem hiding this comment.
You do no need to initialize total_money since this value is set before you make a comparison.
| # - Which driver has the highest average rating? | ||
| #optional--For each driver, on which day did they make the most money? | ||
|
|
||
| trip_data = [ |
There was a problem hiding this comment.
This data structure worked well for you and the logic for your calculations is clear. Consider how your calculations would change had you organized the data by driver.
trip_data = {
driver01: [{ride1}, {ride2},...],
driver02: [{ride1}, {ride2},...],
...
}
Ride ShareWhat We're Looking For
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ride share
Congratulations! You're submitting your assignment.
Comprehension Questions
.map? If so, when? If not, why, or when would be a good opportunity to use it?