Open
Conversation
Ride ShareWhat We're Looking For
Take a quick look at my comment. I think your code is repeating the same piece of work again and again. Part of learning how to structure your data well is learning how to relieve 'stress' from the code with well thought data. Nice work overall! |
dHelmgren
reviewed
Aug 14, 2019
|
|
||
| # Question 1: The number of rides each driver has given? | ||
| def driver_ride_count(driver_id, rides) | ||
| driver_rides = rides.select { |ride| ride [:driver_id] == driver_id } |
There was a problem hiding this comment.
I think it's interesting that you start this method with select, because it means that the first thing that you do is group all of your rides by driver. This process costs your program a little bit of time as it has to loop through the whole array. Could you remove this extra work by restructuring your data?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ride share
Congratulations! You're submitting your assignment.
Comprehension Questions
.map? If so, when? If not, why, or when would be a good opportunity to use it?