Open
Conversation
Ride ShareWhat We're Looking For
Good work on this project, Sara! Overall, your code is very clean, and your solution is very readable, logical, and clever. You did a great job of setting some initial values for different variables like It seems like when you made your data structure, some data mistakenly got put into the wrong place. In general, I don't think this is a huge mistake that I'm concerned over, but it's good to know that until that got fixed, you had some wrong answers. Also, if you had more time, I would love to see some refactoring to include practicing making methods! Again, overall, your project still looks great. Good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ride share
Congratulations! You're submitting your assignment.
Comprehension Questions
.map? If so, when? If not, why, or when would be a good opportunity to use it?.eachloops to iterate over the list of drivers and then the list of rides for each driver. I did not use.map..summethod. However, when I converted them into hash of rides, it became hard to do the calculations.