branches- vi rideshare

[criacuervos]

ride share

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
What did your data structure look like at first? Did this structure evolve over time? Why?	My data structure was at first different hashes with all the information in each trip, without any sort of hierarchy. Then I read through the questions and saw many were about the drivers, so I wanted to nest some data in each driver.
What was your strategy for going through the data structure and gathering information?	I thought it out and realized I wanted it to be nested in a larger set of data.
What was an example of something that was necessary to store in a variable? Why was it necessary, useful, or helpful?
What kinds of iteration did you use? Did you use .map? If so, when? If not, why, or when would be a good opportunity to use it?
Were some calculations easier than others? Why?

[tildeee]

Ride Share

What We're Looking For

Feature	Feedback
Answers the comprehension questions	Some answers were missing; please spend some time on future questions :D
Readable code with consistent indentation and reasonable code style	yes! Fantastic work
Outputs the correct number of rides each driver has given	x
Outputs the total amount of money each driver has made	x
Outputs the average rating for each driver	x
Outputs which driver made the most money	x
Outputs which driver has the highest average rating	x

Hi Vi! I am REALLY excited and impressed and happy with this project submission! The code is extremely clear, readable, concise, clever, logical, and accurate. Well done!

I have a few comments on code style, but overall, I see some great code here. Well done!

[tildeee]

Now that we're working in git, we'll have better ways to upload files, but I wanna point out that you named this file after your PR, which is nice, but I wanted this as worksheet.rb instead of branches- vi rideshare :)

[tildeee]

These variable names prove to me that you know the structure of your data deeply. Nice work!

[tildeee]

In Ruby, we tend to name variables using snake_case, meaning instead of driverName I may see driver_name instead

[tildeee]

Nice use of inject!

[tildeee]

It would probably be a more accurate calculation if we did trip[:rating].to_f instead of to_i

[tildeee]

You end up having this line that calculates average rating based off of an array called trips duplicated. If you had more time to refactor, I may suggest pulling it into a new method. Imagine a method like this:

def calculate_avg_rating(trips)
  return trips.inject(0) { |sum, trip| sum + trip[:rating].to_i } / trips.size 
end

Therefore, this line may be changed to this:

avg_rating = calculate_avg_rating(trips)