Skip to content

Leaves - Yitgop #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rinostar wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Leaves - Yitgop #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3aba18b
1st round of formatting
rinostar Sep 19, 2019
d6cf11f
Second round of styling
rinostar Sep 20, 2019
bd325d1
Get rid of testing borders
rinostar Sep 20, 2019
346385e
fix sponsors
rinostar Sep 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,19 @@
<!DOCTYPE html>

<html>

<head>
<meta charset="utf-8">
<title>Startrly</title>
<link href="normalize.css" rel="stylesheet"/>
<link href="styles.css" rel="stylesheet"/>
</head>
<body>
<div>

<body>

<nav>
<div class="container">

<nav class="nav">
Copy link

@sun-alice sun-alice Sep 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think because the class="nav" is within class="container", you only need to have one class here.
e.g. if you had just div class="container", you can access the "nav" by:

.container nav {
   #formatting stuff
}

<ul>
<li>
Startrly
Expand All @@ -22,15 +27,13 @@
</ul>
</nav>


<section>
<section class="section_1">
<h1>Startrly</h1>
<sub>A catchy tagline for a great solution</sub>
<a href="#">Some Call to Action</a>
</section>


<section>
<section class="section_2">
Copy link

@sun-alice sun-alice Sep 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add quotations before/after the quotes by using ::before and ::after:

e.g.

.section_2 blockquote::before{
  content: open-quote;
}
.section_2  blockquote::after{
  content: close-quote;
}

Copy link

@sun-alice sun-alice Sep 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly with the "--" before Mx. Lorem:

e.g.

.section_2 p::before {
  content: "--"
}

<blockquote>
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
</blockquote>
Expand All @@ -39,8 +42,7 @@ <h1>Startrly</h1>
</p>
</section>


<section>
<section class="section_3">
<h2>Why?</h2>
<ul>
<li>
Expand All @@ -67,8 +69,7 @@ <h2>Why?</h2>
</ul>
</section>


<section>
<section class="section_4">
Copy link

@sun-alice sun-alice Sep 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

section_2 and section_4 are both quotes, and are formatted similarly, so maybe they could be a class!

<blockquote>
Nemo enim ipsam voluptatem quia voluptas sit aspernatur aut odit aut fugit, sed quia consequuntur magni dolores eos qui ratione voluptatem sequi nesciunt.
</blockquote>
Expand All @@ -77,8 +78,7 @@ <h2>Why?</h2>
</p>
</section>


<section>
<section class="section_5">
<h2>Meet the team</h2>
<ul>
<li>
Expand Down Expand Up @@ -109,8 +109,7 @@ <h2>Meet the team</h2>
</ul>
</section>


<section>
<section class="section_6">
<h2>Sponsors</h2>
<ul>
<li>
Expand All @@ -131,8 +130,7 @@ <h2>Sponsors</h2>
</ul>
</section>


<section>
<section class="section_7">
<div>
<h3>Support</h3>
<ul>
Expand Down Expand Up @@ -167,5 +165,7 @@ <h3>About</h3>
</section>

</div>

</body>

</html>
Loading