Ga-Young and Julia by juliabouv · Pull Request #19 · Ada-C12/video-store-api

juliabouv · 2019-11-08T22:21:59Z

Video Store API

Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Comprehension Questions

Question	Answer
Explain how you came up with the design of your ERD, based on the seed data.	Because a customer and movie seeds were provided, we were fairly confident that each of these would be a model and need a controller. Because a rental should hold a customer and a movie (which customer checked out/in which movie), we felt that that should be some kind of “join table” or equivalent - it’s own model at the least.
What would be the Big-O time complexity of your /customers & /movies endpoints? What does the time complexity depend on? Explain your reasoning.	The time complexity of those endpoints would be O(n) where n is the number of customers or movies. As the number of customers and movies increase in the database, it would take that much longer to return every customer and movie.
What is the Big-O time complexity of the `POST /rentals/check-in` endpoint? What does the time complexity depend on? Explain your reasoning.	O(1) assuming that find_by is a direct look up in the database, as movie, customer, and rental all need to be found in order to edit the rental instance.
Describe a set of positive and negative test cases you implemented for a model.	A positive test case implemented in the movie model was being able to instantiate a movie when all correct parameters are given. A negative test case was testing whether a movie could be created when the title was missing or if it wasn’t unique.
Describe a set of positive and negative test cases you implemented for a controller.	The rental controller tests for the checkout action has the positive test case that it can create a new rental and responds with ok status, and the negative case that it responds with bad_request when request fails validation (no customer).
How does your API respond when bad data is sent to it?	The API returns a 400 bad request and a hash containing the error messages of which data was bad.
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	We do not currently have any custom model methods, but feel that if we added the optionals to adjust movie inventory and and customer information when creating and updating rentals, model methods would be necessary.
Do you have any recommendations on how we could improve this project for the next cohort?	I think more explanation into Postman, what it is used for, and how smoke tests work would have been helpful.
Link to Trello	We did not feel it was necessary to create a Trello because there were only two of us. We communicated effectively in person and via slack, and used branches to keep track of our project.
Link to ERD	https://docs.google.com/document/d/1vptSCs8aHkQCYVfWgzWLckc4Ts2Ne7gdWJVP3Ddo1TU/edit?usp=sharing
Summary	Yay, this was so fun to mix both classes for a pair project!

added create movie method and tests

Movie validation

CheezItMan · 2019-11-15T16:12:04Z

Video Store

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good number of commits, granular commits, and good commit messages, both team members contributing
Comprehension questions	Check
General
Business Logic in Models	NONE
All required endpoints return expected JSON data	Check
Requests respond with appropriate HTTP Status Code	Check
Errors are reported	Check
Testing
Passes all Smoke Tests	Check
Model Tests - all relations, validations, and custom functions test positive & negative cases	This is really skimpy testing
Controller Tests - URI parameters and data in the request body have positive & negative cases	Mostly ok, see my inline comments
Overall	Not bad, you don't have any logic in the models and very minimal testing. That said it passes the smoke tests and does serve required JSON. So somethings could be better, but you have the essentials.

CheezItMan · 2019-11-15T16:02:03Z

app/controllers/rentals_controller.rb

@@ -0,0 +1,52 @@
+class RentalsController < ApplicationController
+  def checkout


Nothing to ensure that there are enough movies in the inventory to check it out?

CheezItMan · 2019-11-15T16:02:54Z

app/controllers/rentals_controller.rb

+    end
+  end
+
+  def checkin


The check-in/out logic would make sense to put into a model method

CheezItMan · 2019-11-15T16:04:02Z

test/models/customer_test.rb

+describe Customer do
+  # it "does a thing" do
+  #   value(1+1).must_equal 2
+  # end
+end


Missing tests

CheezItMan · 2019-11-15T16:04:36Z

test/models/movie_test.rb

+  end
+
+  describe "relationships" do
+    it "can have many rentals" do


You might also add that it could have 0 rentals.

CheezItMan · 2019-11-15T16:05:21Z

test/models/movie_test.rb

+    end
+  end
+
+  describe "validations" do


No more validations?

CheezItMan · 2019-11-15T16:05:48Z

test/models/rental_test.rb

@@ -0,0 +1,19 @@
+require "test_helper"
+
+describe Rental do


No test that it's valid with a movie & customer?

CheezItMan · 2019-11-15T16:06:14Z

test/controllers/customers_controller_test.rb

@@ -0,0 +1,28 @@
+require "test_helper"
+
+describe CustomersController do


CheezItMan · 2019-11-15T16:07:01Z

test/controllers/rentals_controller_test.rb

+      expect(body.keys).must_include 'id'
+    end
+
+    it "responds with bad_request when request fails validation (no customer)" do


What about a test when the movie isn't available.

gyjin and others added 29 commits November 5, 2019 13:21

new rails api

d6f1387

Created initial project file

9e9d499

Generated movie and customer models and controllers

4d9bc86

Added columns to Movie and Customer tables

8655787

Added registered_at date to customers

c4b987a

fixed merge conflicts

1b395c0

added index method and tests

1979449

Implemented customer index and tests

f7d5106

added movie fixtures

c5b525e

Updated customer fixture

95392ff

added movie show method and tests

95cd8e0

Merge branch 'master' of https://github.com/juliabouv/video-store-api

40c2e2b

fixed merge conflicts in routes

8c5ed8e

Added rental model

c5b77dc

added create movie method and tests

7509e2d

Merge pull request #1 from juliabouv/movie-create

dbc1c0d

added create movie method and tests

Implemented checkin and checkout

7c934de

Merged master

156360b

added movies checked out count to customer model

88350d6

fixed merge conflicts in schema

681fd7f

changed customer controllers to include movies checked out count

20a1148

added available inventory to movies

db0c1a5

Implemented check-in tests

356e4ef

Merge branch 'master' of https://github.com/juliabouv/video-store-api

78ead4d

added validations for movies and tests

99e157c

merged origin master into branch

9db1f40

Merge pull request #2 from juliabouv/movie-validation

08fb452

Movie validation

added movie model tests

2c12072

removed some comments

fb1f7cc

CheezItMan reviewed Nov 15, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ga-Young and Julia#19

Ga-Young and Julia#19
juliabouv wants to merge 29 commits intoAda-C12:masterfrom
juliabouv:master

juliabouv commented Nov 8, 2019

Uh oh!

CheezItMan commented Nov 15, 2019

Uh oh!

CheezItMan Nov 15, 2019

Uh oh!

CheezItMan Nov 15, 2019

Uh oh!

CheezItMan Nov 15, 2019

Uh oh!

CheezItMan Nov 15, 2019

Uh oh!

CheezItMan Nov 15, 2019

Uh oh!

CheezItMan Nov 15, 2019

Uh oh!

CheezItMan Nov 15, 2019

Uh oh!

CheezItMan Nov 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,52 @@
		class RentalsController < ApplicationController
		def checkout

		@@ -0,0 +1,28 @@
		require "test_helper"

		describe CustomersController do

Conversation

juliabouv commented Nov 8, 2019

Video Store API

Comprehension Questions

Uh oh!

CheezItMan commented Nov 15, 2019

Video Store

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants