Skip to content

Time-Corinna-Olga#11

Open
corinna-fab wants to merge 6 commits intoAda-C13:masterfrom
corinna-fab:master
Open

Time-Corinna-Olga#11
corinna-fab wants to merge 6 commits intoAda-C13:masterfrom
corinna-fab:master

Conversation

@corinna-fab
Copy link

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature Feedback
What are the components that make up a method? The components of a method include: signature, parameters, the block, and arguments.
What are the advantages of using git when collaboratively working on one code base? Using git as a collaborative work tool allows for more efficient code development by allowing for multiple coders to write, merge, and submit code on the same project in real time.
What kind of relationship did you and your pair have with the unit tests? We tested our methods block-by-block against the unit tests by commenting out (or using skip) to test if a particular part of the program functioned correctly before moving on.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? We used the .include method when checking to see if the input word complied with the available letters, which allowed us to compare the arrays element by element. We also originally used the max_by method but ultimately found that it was repetitive when taken in conjunction with the other filters we'd set up.
What was one method you and your pair used to debug code? We mostly relied on puts statements to debug.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? Two things we discussed include: taking a step back to understand each other's work speeds and finding comfortable pace for both people, and relying less on structured driver/navigator time and instead allowing natural trading back and forth based on each other's skills.

@corinna-fab corinna-fab changed the title Adagrams-Corinna-Olga Time-Corinna-Olga Feb 14, 2020
@jmaddox19
Copy link

Adagrams

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.) ✔️
Uses correct syntax for conditional logic and iteration ✔️
Practices git with at least 3 small commits and meaningful commit messages ✔️ Yay! 👏👏👏
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures ✔️
Practices pair programming; the reflection question on pair programming is answered ✔️

Functional Requirements

Functional Requirement yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) ✔️
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass ✔️
Utilizes unit tests to verify code; all tests for score_word pass ✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass ✔️

Overall Feedback

Great work!!

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 4+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard) 0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants