Skip to content

Conversation

@Hannah0124
Copy link

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Question Answer
What are the components that make up a method? The components that make up a method include: the def, the method name, the parameters, the action block, and the end. When the method is called, arguments are passed through it in parentheses. A method needs to return a value to invoke it. Otherwise, a method will return the value that was returned from the last evaluated statement.
What are the advantages of using git when collaboratively working on one code base? The advantages of using git when collaboratively working on one code base are that both parties can access the most up-to-date code of a project. Other advantages include having a repository that doesn't rely on a computer's hardware and/or "local" files; i.e., if one person's computer crashes, it's not the end of the world (or the beginning of a new draft of the project).
What kind of relationship did you and your pair have with the unit tests? We tested various inputs, including edge cases against the unit tests periodically (generally whenever we finished a wave, but sometimes during wave development.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? We used the enumerable mixin .map for wave four. It was helpful because it shortened what was an each loop into a single line of code.
What was one method you and your pair used to debug code? We used the enumerable mixin .map for wave four. It was helpful because it shortened what was an each loop into a single line of code.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? One of the things we talked about was having a guess culture in common. We asked each other whether we preferred people to address us in ask culture or guess culture lingo, and we both responded that we preferred people to use ask culture lingo when working with us. We also did our best to assert that it was ok to suggest comments and/or improvements to the typer's code.

@jmaddox19
Copy link

Adagrams

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.) ✔️
Uses correct syntax for conditional logic and iteration ✔️
Practices git with at least 3 small commits and meaningful commit messages ✔️ Yay! 👏👏👏
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures ✔️
Practices pair programming; the reflection question on pair programming is answered ✔️

Functional Requirements

Functional Requirement yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) ✔️
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass ✔️
Utilizes unit tests to verify code; all tests for score_word pass ✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass ✔️

Overall Feedback

Great work!! Code is clean, concise and readable.

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 4+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard) 0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants