Skip to content

Emily and Vera - Time#13

Open
snowistaken wants to merge 6 commits intoAda-C13:masterfrom
snowistaken:master
Open

Emily and Vera - Time#13
snowistaken wants to merge 6 commits intoAda-C13:masterfrom
snowistaken:master

Conversation

@snowistaken
Copy link

@snowistaken snowistaken commented Feb 14, 2020

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature Feedback
What are the components that make up a method? The method signature, parameters, and arguments.
What are the advantages of using git when collaboratively working on one code base? Gi is advantageous because it makes it much easier to transfers entire projects and small changes to those projects between partners, as well as having a backup in case files are lost on one computer.
What kind of relationship did you and your pair have with the unit tests? Our relationship with the unit tests was good. They were very helpful in determining whether or not our code could properly execute the required functions, and if not, why they could not do so.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? One enumerable we used from the jigsaw was the min_by/max_by methods. These were very helpful in determining the final winner of the game as it made it easy to find the highest score or longest length.
What was one method you and your pair used to debug code? We mostly used the unit tests. However, when we did not use the unit tests we used the puts method.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?

@jmaddox19
Copy link

Adagrams

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.) ✔️
Uses correct syntax for conditional logic and iteration ✔️
Practices git with at least 3 small commits and meaningful commit messages ✔️ Yay! 👏👏👏
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures ✔️
Practices pair programming; the reflection question on pair programming is answered ✔️

Functional Requirements

Functional Requirement yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) ✔️
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass ✔️
Utilizes unit tests to verify code; all tests for score_word pass ✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass ✔️

Overall Feedback

Great work!!

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 4+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard) 0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable ✅ The comments definitely help :)
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants