Space - Diana & Lak

[dnguye2]

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature	Feedback
What are the components that make up a method?	There's a method signature, parameter(s), argument(s), and block.
What are the advantages of using git when collaboratively working on one code base?	You and your collaborators can see previous changes. If needed you and/or your collaborators have a copy of previous versions. Additionally, it is easy to merge changes.
What kind of relationship did you and your pair have with the unit tests?	The unit tests guided the code development and design of the methods.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful?	Yes, we used .include? (Wave 2), .empty(Wave 3), .map (Wave 3), each (Wave 2 & 4. They were helpful to shorten the code and provide more readability.
What was one method you and your pair used to debug code?	We used the terminal to test out snippets of code blocks we were having problems with. It would be useful to start learning to use the VS Code debugger in the future. Having the methods also helped in debugging and figuring out how to solve the problem in smaller chunks.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	(1) We worked well as a pair because of the constant communication and willingness to listen and test each other's ideas and processes. (2) Having pair programmed broadened our problem solving in code because we had to hear each other's different thought processes and inputs. We agreed that doing this project alone would have been very challenging.

[jmaddox19]

Calculator

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.)	✔️
Uses correct syntax for conditional logic and iteration	✔️
Practices git with at least 3 small commits and meaningful commit messages	✔️ Yay! 👏👏👏
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures	✔️
Practices pair programming; the reflection question on pair programming is answered	✔️

Functional Requirements

Functional Requirement	yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.)	✔️ The data structures in draw_letters certainly work but it's generally not considered best practice to use two array, with one acting as the keys and the other acting as the values. It's best to use a hash in such cases. (Please chat with me if my messaging here isn't clear)
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass	✔️
Utilizes unit tests to verify code; all tests for score_word pass	✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass	✔️

Overall Feedback

Great work! There are a couple funky things I noticed in part 1 that I left comments on in a code review on github. Please take a look at those.

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	4+ in Code Review && 3+ in Functional Requirements	✔️
Yellow (Approaches Standards)	3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard)	0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized