Skip to content

Conversation

@ktvoort123
Copy link

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature Feedback
What are the components that make up a method? Signature (name & parameters) & block
What are the advantages of using git when collaboratively working on one code base? We are able to both contribute to the code, easily see differences and keep code on our computers up-to-date.
What kind of relationship did you and your pair have with the unit tests? We found it was easy to test out our methods and figure out what was working and what was failing.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? We did not use methods from the Enumerable jigsaw.
What was one method you and your pair used to debug code? We used rake often. For a test that we failed, looking at the unit test helped us clarify what condition we did not consider.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? 1. We switched the driver and navigator positions every thirty minutes, which worked very well. 2. We allowed spiking and always came to a conclusion in an agreed upon & reasonable time.

@jmaddox19
Copy link

Calculator

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.) ✔️
Uses correct syntax for conditional logic and iteration ✔️
Practices git with at least 3 small commits and meaningful commit messages Technically there are 3+ commits but didn't start committing until the project was practically done. Definitely worth committing throughout your work on the project in the future :)
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures ✔️
Practices pair programming; the reflection question on pair programming is answered ✔️ Glad y'all were able to benefit from switching off and doing spikes! :)

Functional Requirements

Functional Requirement yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) ✔️
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass ✔️
Utilizes unit tests to verify code; all tests for score_word pass ✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass ✔️

Overall Feedback

Great work!!

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 4+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard) 0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants