Skip to content

Space - Jessica & Lee#18

Open
seaweeddol wants to merge 21 commits intoAda-C13:masterfrom
theomoondev:master
Open

Space - Jessica & Lee#18
seaweeddol wants to merge 21 commits intoAda-C13:masterfrom
theomoondev:master

Conversation

@seaweeddol
Copy link

@seaweeddol seaweeddol commented Feb 14, 2020

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature Feedback
What are the components that make up a method? The method signature (includes name and parameters) and the code block.
What are the advantages of using git when collaboratively working on one code base? Ensures that collaborators are working off the same version of a file; if not, allows for collaborators to solve merge conflicts without overwriting code. Helpful for seeing what everyone has contributed to the code, assuming they are committing their changes. If a file needs to be reverted to an earlier version, git allows collaborators to rollback to a previous commit.
What kind of relationship did you and your pair have with the unit tests? They were definitely helpful for seeing if our code was working correctly and satisfied the project requirements, and it helped us rely less on printing values in the terminal. We hit a snag because we were printing variables instead of returning them, which was passing tests because Ruby returns implicitly, but were able to resolve it.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? Map on lines 35, 79, and 118; helpful for creating arrays. Max_by on line 83; helpful for finding the highest score. Min_by on line 94; helpful for finding the shortest word length. Sort_by on line 98; helpful for making sure that the correct word was selected from tied_scores. Group_by on line 122; used it to reduce the amount of data that the program had to sort through when running the is_in_english_dict? method.
What was one method you and your pair used to debug code? Primarily used the rake tests and occasionally printing variables in the terminal. We also ran the wave-#-game.rb files.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? We discussed writing more pseudocode before starting actual coding in order to have a better grasp on what needed to be done. This would be especially helpful in future pair projects where we may not have as similar styles of communication, learning, or applying concepts. We felt like we had a pretty equal balance of being driver/navigator and that each role was clear but also collaborative.

@jmaddox19
Copy link

Calculator

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.) ✔️
Uses correct syntax for conditional logic and iteration ✔️
Practices git with at least 3 small commits and meaningful commit messages ✔️ Yay! 👏👏👏
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures ✔️
Practices pair programming; the reflection question on pair programming is answered ✔️

Functional Requirements

Functional Requirement yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) ✔️
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass ✔️
Utilizes unit tests to verify code; all tests for score_word pass ✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass ✔️

Overall Feedback

Great work!! Super readable! Love the learning of starting with more pseudocode, especially when pairing. I totally agree :)

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 4+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard) 0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants