Skip to content

Adagrams - Becca Roach and Shonda Warren - Space#19

Open
RebeccaRoach wants to merge 16 commits intoAda-C13:masterfrom
RebeccaRoach:master
Open

Adagrams - Becca Roach and Shonda Warren - Space#19
RebeccaRoach wants to merge 16 commits intoAda-C13:masterfrom
RebeccaRoach:master

Conversation

@RebeccaRoach
Copy link

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature Feedback
What are the components that make up a method? A method is composed of a method signature, body, and end statement. It starts with "def", is given a name to be invoked later, and any parameters that are necessary.
What are the advantages of using git when collaboratively working on one code base? Git helps with version control in allowing multiple collaborators to modify and sync files to one repository. Working with git allows programmers to share a master remote codebase that lives on Github's servers, while the partners can fetch, push, pull, and compare differences (diff) between files as needed. In the end, partners can stash their own changes, merge changes back with the master remote version, and other useful collaboration functions.
What kind of relationship did you and your pair have with the unit tests? Though at first we had trouble running rake due to problems with installing gems without the sudo command, eventually we were able to use the unit tests to sequentially debug our methods. We also tested our file with the terminal and other resources, taking advantage of hard-coding test data to make sure a method was working the way we anticipated before running rake. We anticipate using unit tests even more in the future to help debug our projects.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? We used .map in waves 1-3 and .drop in wave 1. .Drop allowed us to conveniently keep only 10 items (specifically the last 10 with this method) from the total original pool of available letter tiles after randomizing them with .shuffle. .Map allowed us to construct our pool of total available letter tiles by copying each letter the specified number of times, as well as keep track as we looped through the alphabet of letters whether a played letter was found in the dealt hand or not or to collect the point values for each letter into arrays, which we collapsed with flatten and summed up with .sum to get total word scores. We also investigated using .zip to associate the word with its score in separate arrays but ended up not using that approach in the final code.
What was one method you and your pair used to debug code? We used the rake file, the adagrams_test.rb file, and plentiful puts statements to debug our code. The test file in particular helped us see what data types and values were expected.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? We talked about how we felt we collaborated well both in terms of workload and communication style. When one of us had a hunch about a particular way to approach the problem, we felt comfortable and confident asking to drive, which worked out well. Similarly, when one of us didn't understand something, we were clear in asking the other to pause and explain in more detail. This helped us both to learn new methods because we experimented together, and feel more capable of understanding someone else's coding style.

@jmaddox19
Copy link

Calculator

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.) ✔️
Uses correct syntax for conditional logic and iteration ✔️
Practices git with at least 3 small commits and meaningful commit messages ✔️ Yay! 👏👏👏
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures ✔️
Practices pair programming; the reflection question on pair programming is answered ✔️

Functional Requirements

Functional Requirement yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) ✔️
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass ✔️
Utilizes unit tests to verify code; all tests for score_word pass ✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass ✔️

Overall Feedback

Great work!

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 4+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard) 0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants