Skip to content

Conversation

@yieknee
Copy link

@yieknee yieknee commented Feb 15, 2020

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature Feedback
What are the components that make up a method? A method signature (name & parameters), block (instructions), call invoking arguments.
What are the advantages of using git when collaboratively working on one code base? It allows you to both make updates to the code and keeps track of those updates and allows for merges. It's a solid record of commits, so your code is safe if one or both people lose it.
What kind of relationship did you and your pair have with the unit tests? We used the unit tests to check if our code was working. We failed it (red), built our code, run the test and see green, and refactor and run again.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? Yes we used .select, .include?, and .max. They were helpful in getting us to a specific value or key we wanted.
What was one method you and your pair used to debug code? We extensively used he debugging tool to debug. We also used the whiteboard many time to track our thoughts and used p and puts statements.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? If you're driving, drive from your own laptop and when you're done push to git and your partner pulls and starts driving from their machine. Also, set a timer for driving so you don't get carried away and the driving is disproportionate.

@jmaddox19
Copy link

Calculator

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.) ✔️
Uses correct syntax for conditional logic and iteration ✔️
Practices git with at least 3 small commits and meaningful commit messages ✔️ Yay! 👏👏👏
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures ✔️
Practices pair programming; the reflection question on pair programming is answered ✔️

Functional Requirements

Functional Requirement yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) ✔️
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass ✔️
Utilizes unit tests to verify code; all tests for score_word pass ✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass ✔️

Overall Feedback

Great work!

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 4+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard) 0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation Almost! something funky happened on line 6-7
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants