Space - Chelsea#30
Open
ChelseaC13 wants to merge 33 commits intoAda-C13:masterfrom
Open
Conversation
…or and the space between buttons to be fixed
…T sorted by votes
…ling to the columns
…method in work model
Media RankerFunctional Requirements: Manual Testing
Major Learning Goals/Code Review
Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code
Testing Rails Apps
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
kaidamasaki
reviewed
Jun 3, 2020
kaidamasaki
left a comment
kaidamasaki
left a comment
There was a problem hiding this comment.
Good job! There were a few missed things but well done overall. 😃
|
|
||
| @import "**/*"; | ||
|
|
||
| .orange-header{ |
There was a problem hiding this comment.
You shouldn't have class names refer to things like colors in them. They should be named based on what the sections mean.
(An example from your code of something with a good class name is "spotlight".)
| .orange-header{ | ||
| font-weight: bold; | ||
| font-size: 34px; | ||
| color: #ff5721 !important; |
There was a problem hiding this comment.
You really should avoid using !important if you can.
Especially in production code. It will cause headaches if other users are trying to make styles work with yours. You should rely on precedence instead.
Comment on lines
+12
to
+17
| work_id = params[:id] | ||
| @work = Work.find_by(id: work_id) | ||
| if @work.nil? | ||
| redirect_to root_path | ||
| return | ||
| end |
There was a problem hiding this comment.
This is the kind of code that makes sense to put in a controller filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?Assignment Submission: Media Ranker
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
sessionandflash? What is the difference between them?